starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1345] [MERGED] fix(bar): limit new state freq on time and date #1341

New Issue
Closed
opened 2026-01-05 14:54:56 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1345
Author: @CtByte
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @LGUG2Z

Base: master ← Head: time_update

📝 Commits (1)

  • 697ef69 fix(bar): limit new state freq on time and date

📊 Changes

2 files changed (+122 additions, -56 deletions)

View changed files

📝 komorebi-bar/src/date.rs (+38 -16)
📝 komorebi-bar/src/time.rs (+84 -40)

📄 Description

This commit limits the number of times the time and date widgets get a new state.

Even though having a limit of 1 second on the ui repaint, when the bar is focused or hovered, this is ignored and state of these widgets were updated many more times a second.

The time widget looked less accurate and lagging (especially with multiple showing seconds) so the refresh interval is set to be 500 ms instead of 1 second.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1345 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `time_update` --- ### 📝 Commits (1) - [`697ef69`](https://github.com/LGUG2Z/komorebi/commit/697ef695109fc7cbd95d2b553d1cca223ced3536) fix(bar): limit new state freq on time and date ### 📊 Changes **2 files changed** (+122 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/date.rs` (+38 -16) 📝 `komorebi-bar/src/time.rs` (+84 -40) </details> ### 📄 Description This commit limits the number of times the time and date widgets get a new state. Even though having a limit of 1 second on the ui repaint, when the bar is focused or hovered, this is ignored and state of these widgets were updated many more times a second. The time widget looked less accurate and lagging (especially with multiple showing seconds) so the refresh interval is set to be 500 ms instead of 1 second. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:56 +01:00
adam closed this issue 2026-01-05 14:54:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?