starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1337] [MERGED] fix(wm): update layer on cross monitor moves #1336

New Issue
Closed
opened 2026-01-05 14:54:55 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1337
Author: @alex-ds13
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/change-layer-on-cross-monitor-moves

📝 Commits (1)

  • bfdb9b8 fix(wm): update layer on cross monitor moves

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 komorebi/src/monitor.rs (+4 -0)
📝 komorebi/src/window_manager.rs (+3 -0)

📄 Description

There was an issue where if you tried to move a floating window to another monitor using a command like komorebic cycle-move-to-monitor 1 it would move the window correctly, but the target workspace layer wouldn't change, which probably meant it would still be as Tiling so if you tried to move the floating window with the new floating window moves it would behave as if it was a tile move and actually moved the window across monitor again if that was the direction you moved, any other direction would just be ignored.

This PR fixes that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1337 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/change-layer-on-cross-monitor-moves` --- ### 📝 Commits (1) - [`bfdb9b8`](https://github.com/LGUG2Z/komorebi/commit/bfdb9b853347474babf839dd17bd011b14ecb713) fix(wm): update layer on cross monitor moves ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/monitor.rs` (+4 -0) 📝 `komorebi/src/window_manager.rs` (+3 -0) </details> ### 📄 Description There was an issue where if you tried to move a floating window to another monitor using a command like `komorebic cycle-move-to-monitor 1` it would move the window correctly, but the target workspace layer wouldn't change, which probably meant it would still be as `Tiling` so if you tried to move the floating window with the new floating window moves it would behave as if it was a tile move and actually moved the window across monitor again if that was the direction you moved, any other direction would just be ignored. This PR fixes that. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:55 +01:00
adam closed this issue 2026-01-05 14:54:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?