[PR #1307] [MERGED] fix(bar): always add stroke on selected_frame #1312

New Issue

2026-01-05T14:54:51+01:00

adam commented

2026-01-05 14:54:51 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1307
Author: @CtByte
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/1/2025
Merged by: @LGUG2Z

Base: master ← Head: egui_frame_stroke

📝 Commits (1)

edaadde fix(bar): always add stroke on selected_frame

📊 Changes

1 file changed (+18 additions, -8 deletions)

View changed files

📝 komorebi-bar/src/selected_frame.rs (+18 -8)

📄 Description

This commit fixes a breaking change on the selected_frame that was introduced by eframe version 0.31.

In this version, the stroke is drawn on the inside of a Frame instead it being drawn on the outside like before. This now means that a stroke needs to be added on all the states of the Frame in order to avoid all the elements to be moving around on hover.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1307 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/1/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `egui_frame_stroke` --- ### 📝 Commits (1) - [`edaadde`](https://github.com/LGUG2Z/komorebi/commit/edaadded715090694cf24a18765284bd88c3f5c2) fix(bar): always add stroke on selected_frame ### 📊 Changes **1 file changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/selected_frame.rs` (+18 -8) </details> ### 📄 Description This commit fixes a breaking change on the selected_frame that was introduced by eframe version 0.31. In this version, the stroke is drawn on the inside of a Frame instead it being drawn on the outside like before. This now means that a stroke needs to be added on all the states of the Frame in order to avoid all the elements to be moving around on hover. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:51 +01:00

adam closed this issue

2026-01-05 14:54:51 +01:00

adam referenced this issue

2026-01-05 14:54:53 +01:00

[PR #1327] [MERGED] feat(bar): added timezone to time widget #1325

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1312