starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1307] [MERGED] fix(bar): always add stroke on selected_frame #1312

New Issue
Closed
opened 2026-01-05 14:54:51 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1307
Author: @CtByte
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/1/2025
Merged by: @LGUG2Z

Base: master ← Head: egui_frame_stroke

📝 Commits (1)

  • edaadde fix(bar): always add stroke on selected_frame

📊 Changes

1 file changed (+18 additions, -8 deletions)

View changed files

📝 komorebi-bar/src/selected_frame.rs (+18 -8)

📄 Description

This commit fixes a breaking change on the selected_frame that was introduced by eframe version 0.31.

In this version, the stroke is drawn on the inside of a Frame instead it being drawn on the outside like before. This now means that a stroke needs to be added on all the states of the Frame in order to avoid all the elements to be moving around on hover.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1307 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/1/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `egui_frame_stroke` --- ### 📝 Commits (1) - [`edaadde`](https://github.com/LGUG2Z/komorebi/commit/edaadded715090694cf24a18765284bd88c3f5c2) fix(bar): always add stroke on selected_frame ### 📊 Changes **1 file changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/selected_frame.rs` (+18 -8) </details> ### 📄 Description This commit fixes a breaking change on the selected_frame that was introduced by eframe version 0.31. In this version, the stroke is drawn on the inside of a Frame instead it being drawn on the outside like before. This now means that a stroke needs to be added on all the states of the Frame in order to avoid all the elements to be moving around on hover. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:51 +01:00
adam closed this issue 2026-01-05 14:54:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?