starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1301] [MERGED] Fix(borders): multiple borders fixes #1310

New Issue
Closed
opened 2026-01-05 14:54:50 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1301
Author: @alex-ds13
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @LGUG2Z

Base: master ← Head: fix(borders)/stack-borders-not-getting-destroyed

📝 Commits (3)

  • 68998a7 feat(wm): toggle layer moves all windows
  • 5abe44b fix(borders): stop leaking memory on borders
  • 7f817b1 fix(wm): stack on all directions even when on a stack

📊 Changes

6 files changed (+275 additions, -91 deletions)

View changed files

📝 komorebi/src/border_manager/border.rs (+0 -2)
📝 komorebi/src/border_manager/mod.rs (+188 -82)
📝 komorebi/src/process_command.rs (+25 -4)
📝 komorebi/src/window.rs (+24 -0)
📝 komorebi/src/window_manager.rs (+14 -0)
📝 komorebi/src/windows_api.rs (+24 -3)

📄 Description

This PR includes 3 commits:

  • The first commit changes the komorebic toggle-workspace-layer command to move up/down all windows of the layer. So if you are on the Tiling layer and toggle the layer it will bring all floating windows to front so you can see them and cycle through them. Once you toggle again, the floating windows are sent back again.
  • The second commit fixes a memory leak on the border manager. More information is provided on the commit message itself
  • The third commit fixes an issue with the stacking of windows, which was causing issues with the borders. The fix also makes possible to stack windows on all directions. Previously if you had focus on a stack and tried to call stack-window on a direction with index higher than the current focus (usually right or down), it wouldn't work! Now it does.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1301 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(borders)/stack-borders-not-getting-destroyed` --- ### 📝 Commits (3) - [`68998a7`](https://github.com/LGUG2Z/komorebi/commit/68998a72a1c9a663d7592820a09d74913dfb51d2) feat(wm): toggle layer moves all windows - [`5abe44b`](https://github.com/LGUG2Z/komorebi/commit/5abe44b1a96576c8701847f253aa2e7d00a26651) fix(borders): stop leaking memory on borders - [`7f817b1`](https://github.com/LGUG2Z/komorebi/commit/7f817b192f73f841a20dea9815cf5e6704936287) fix(wm): stack on all directions even when on a stack ### 📊 Changes **6 files changed** (+275 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/border_manager/border.rs` (+0 -2) 📝 `komorebi/src/border_manager/mod.rs` (+188 -82) 📝 `komorebi/src/process_command.rs` (+25 -4) 📝 `komorebi/src/window.rs` (+24 -0) 📝 `komorebi/src/window_manager.rs` (+14 -0) 📝 `komorebi/src/windows_api.rs` (+24 -3) </details> ### 📄 Description This PR includes 3 commits: - The first commit changes the `komorebic toggle-workspace-layer` command to move up/down all windows of the layer. So if you are on the `Tiling` layer and toggle the layer it will bring all floating windows to front so you can see them and cycle through them. Once you toggle again, the floating windows are sent back again. - The second commit fixes a memory leak on the border manager. More information is provided on the commit message itself - The third commit fixes an issue with the stacking of windows, which was causing issues with the borders. The fix also makes possible to stack windows on all directions. Previously if you had focus on a stack and tried to call `stack-window` on a direction with index higher than the current focus (usually right or down), it wouldn't work! Now it does. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:50 +01:00
adam closed this issue 2026-01-05 14:54:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1310
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?