starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1295] [MERGED] fix(wm): monitor reconnect after komorebi start #1306

New Issue
Closed
opened 2026-01-05 14:54:49 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1295
Author: @alex-ds13
Created: 2/24/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/monitor-reconnect-after-komorebi-start

📝 Commits (2)

  • da8337b fix(wm): properly load 1st time connected monitor
  • d20d52b fix(bar): apply offset when monitor reconnects

📊 Changes

2 files changed (+32 additions, -3 deletions)

View changed files

📝 komorebi-bar/src/bar.rs (+6 -0)
📝 komorebi/src/monitor_reconciliator/mod.rs (+26 -3)

📄 Description

This PR fixes an issue where if you started komorebi without one of the monitors and then reconnected the monitor later it wasn't properly loading the data from win32-display-data.

It also fixes a bug on the komorebi-bar by making sure the bar applies the work_area_offset correctly after a monitor reconnects. Since if it is the first time the monitor is connecting it won't have the offset cached yet.

Fixes #1294

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1295 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/monitor-reconnect-after-komorebi-start` --- ### 📝 Commits (2) - [`da8337b`](https://github.com/LGUG2Z/komorebi/commit/da8337ba2a90eae0682324670dd099be4c3ed11a) fix(wm): properly load 1st time connected monitor - [`d20d52b`](https://github.com/LGUG2Z/komorebi/commit/d20d52b9ef205540938d0d6eae6147c37bcf3ea7) fix(bar): apply offset when monitor reconnects ### 📊 Changes **2 files changed** (+32 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/bar.rs` (+6 -0) 📝 `komorebi/src/monitor_reconciliator/mod.rs` (+26 -3) </details> ### 📄 Description This PR fixes an issue where if you started komorebi without one of the monitors and then reconnected the monitor later it wasn't properly loading the data from `win32-display-data`. It also fixes a bug on the komorebi-bar by making sure the bar applies the `work_area_offset` correctly after a monitor reconnects. Since if it is the first time the monitor is connecting it won't have the offset cached yet. Fixes #1294 <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:49 +01:00
adam closed this issue 2026-01-05 14:54:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?