[PR #1240] [MERGED] fix(wm): stop wrongfully removing layout-flip #1268

New Issue

2026-01-05T14:54:42+01:00

adam commented

2026-01-05 14:54:42 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1240
Author: @alex-ds13
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @LGUG2Z

Base: master ← Head: fix(wm)/layout-flip-removed-by-layout-rules

📝 Commits (1)

769e187 fix(wm): stop wrongfully removing layout-flip

📊 Changes

2 files changed (+1 additions, -5 deletions)

View changed files

📝 komorebi/src/workspace.rs (+0 -4)
📝 komorebic/src/main.rs (+1 -1)

📄 Description

This commit removes the code on the workspace update on layout-rules where it was setting the layout-flip to None if the layout was different from BSP. This appears to be some old code when the layout-flip would only apply to the BSP layout. However now it appears to apply to all layouts so this code shouldn't exist. This commit also changes the docs from the FlipLayout command to remove the statement that only applied to BSP since it is no longer true.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1240 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(wm)/layout-flip-removed-by-layout-rules` --- ### 📝 Commits (1) - [`769e187`](https://github.com/LGUG2Z/komorebi/commit/769e187a28e67642fa25371d34512d3a2eb1b99f) fix(wm): stop wrongfully removing layout-flip ### 📊 Changes **2 files changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/workspace.rs` (+0 -4) 📝 `komorebic/src/main.rs` (+1 -1) </details> ### 📄 Description This commit removes the code on the workspace `update` on `layout-rules` where it was setting the `layout-flip` to `None` if the layout was different from `BSP`. This appears to be some old code when the layout-flip would only apply to the `BSP` layout. However now it appears to apply to all layouts so this code shouldn't exist. This commit also changes the docs from the `FlipLayout` command to remove the statement that only applied to `BSP` since it is no longer true.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:42 +01:00

adam closed this issue

2026-01-05 14:54:42 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1268