starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1240] [MERGED] fix(wm): stop wrongfully removing layout-flip #1268

New Issue
Closed
opened 2026-01-05 14:54:42 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1240
Author: @alex-ds13
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @LGUG2Z

Base: master ← Head: fix(wm)/layout-flip-removed-by-layout-rules

📝 Commits (1)

  • 769e187 fix(wm): stop wrongfully removing layout-flip

📊 Changes

2 files changed (+1 additions, -5 deletions)

View changed files

📝 komorebi/src/workspace.rs (+0 -4)
📝 komorebic/src/main.rs (+1 -1)

📄 Description

This commit removes the code on the workspace update on layout-rules where it was setting the layout-flip to None if the layout was different from BSP. This appears to be some old code when the layout-flip would only apply to the BSP layout. However now it appears to apply to all layouts so this code shouldn't exist. This commit also changes the docs from the FlipLayout command to remove the statement that only applied to BSP since it is no longer true.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1240 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(wm)/layout-flip-removed-by-layout-rules` --- ### 📝 Commits (1) - [`769e187`](https://github.com/LGUG2Z/komorebi/commit/769e187a28e67642fa25371d34512d3a2eb1b99f) fix(wm): stop wrongfully removing layout-flip ### 📊 Changes **2 files changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/workspace.rs` (+0 -4) 📝 `komorebic/src/main.rs` (+1 -1) </details> ### 📄 Description This commit removes the code on the workspace `update` on `layout-rules` where it was setting the `layout-flip` to `None` if the layout was different from `BSP`. This appears to be some old code when the layout-flip would only apply to the `BSP` layout. However now it appears to apply to all layouts so this code shouldn't exist. This commit also changes the docs from the `FlipLayout` command to remove the statement that only applied to `BSP` since it is no longer true. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:42 +01:00
adam closed this issue 2026-01-05 14:54:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1268
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?