starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1203] [MERGED] fix(bar): prevent komorebi connection from staling #1252

New Issue
Closed
opened 2026-01-05 14:54:38 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1203
Author: @alex-ds13
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/26/2024
Merged by: @LGUG2Z

Base: master ← Head: fix(bar)/komorebi-connection-was-getting-stuck

📝 Commits (1)

  • 82b5776 fix(bar): prevent komorebi connection from staling

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 komorebi-bar/src/main.rs (+4 -0)

📄 Description

Sometimes the bar would randomly stop receiving notifications from komorebi and would stop updating the Komorebi widget. This feels to me that the reason is the same one that used to happen on the process_commands from komorebi where the socket would get stuck reading an empty connection. This commit adds a read timeout to the socket to prevent that from happening and hopefully it should stop those situations where the bar would stop receiving notifications.

There were some users reporting on Discord that the bar would sometime stop updating the workspaces widget and I have faced that as well! Hopefully this should fix that. I looked if there was an opened issue on github related to this but couldn't find any, so maybe it was just reported on Discord.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1203 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/26/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(bar)/komorebi-connection-was-getting-stuck` --- ### 📝 Commits (1) - [`82b5776`](https://github.com/LGUG2Z/komorebi/commit/82b5776ed36976b13bb73927931c6d0e985304ab) fix(bar): prevent komorebi connection from staling ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/main.rs` (+4 -0) </details> ### 📄 Description Sometimes the bar would randomly stop receiving notifications from komorebi and would stop updating the `Komorebi` widget. This feels to me that the reason is the same one that used to happen on the `process_commands` from `komorebi` where the socket would get stuck reading an empty connection. This commit adds a read timeout to the socket to prevent that from happening and hopefully it should stop those situations where the bar would stop receiving notifications. There were some users reporting on Discord that the bar would sometime stop updating the workspaces widget and I have faced that as well! Hopefully this should fix that. I looked if there was an opened issue on github related to this but couldn't find any, so maybe it was just reported on Discord. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:38 +01:00
adam closed this issue 2026-01-05 14:54:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1252
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?