starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1192] [MERGED] fix(bar): network widget spacing #1249

New Issue
Closed
opened 2026-01-05 14:54:37 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1192
Author: @CtByte
Created: 12/19/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @LGUG2Z

Base: master ← Head: bar_widget_spacing_network

📝 Commits (1)

  • 0d9e80a fix(bar): network widget spacing

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 komorebi-bar/src/network.rs (+8 -4)

📄 Description

There was an issue with the network widget when the widget spacing was applied on an alignment.

The same RenderConfig must be used for an alignment in order to maintain widget spacing, as it is necessary to remember the first time the apply_on_widget is called.
A boolean is used for that, which was not passed on to other widgets from the network widget, this is now fixed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1192 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 12/19/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `bar_widget_spacing_network` --- ### 📝 Commits (1) - [`0d9e80a`](https://github.com/LGUG2Z/komorebi/commit/0d9e80aaf1f7e566a8d7abf82af9aa3ac11c2194) fix(bar): network widget spacing ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/network.rs` (+8 -4) </details> ### 📄 Description There was an issue with the network widget when the widget spacing was applied on an alignment. The same `RenderConfig` must be used for an alignment in order to maintain widget spacing, as it is necessary to remember the first time the `apply_on_widget` is called. A boolean is used for that, which was not passed on to other widgets from the network widget, this is now fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:37 +01:00
adam closed this issue 2026-01-05 14:54:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?