[PR #1194] [MERGED] fix(bar): update widgets background color properly #1247

New Issue

2026-01-05T14:54:37+01:00

adam commented

2026-01-05 14:54:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1194
Author: @alex-ds13
Created: 12/21/2024
Status: ✅ Merged
Merged: 12/21/2024
Merged by: @LGUG2Z

Base: master ← Head: fix(bar)/widgets-bg-not-updating

📝 Commits (1)

61a48ac fix(bar): update widgets background color properly

📊 Changes

2 files changed (+11 additions, -0 deletions)

View changed files

📝 komorebi-bar/src/bar.rs (+7 -0)
📝 komorebi-bar/src/komorebi.rs (+4 -0)

📄 Description

Previously when changing between themes with different backgrounds the widget's background color was not updating because they take the bg color from the RenderConfig which was only being updated on apply_config, now we also pass the RenderConfig to the apply_theme function and update it's background_color there as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1194 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/21/2024 **Status:** ✅ Merged **Merged:** 12/21/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix(bar)/widgets-bg-not-updating` --- ### 📝 Commits (1) - [`61a48ac`](https://github.com/LGUG2Z/komorebi/commit/61a48ac023ae33ede8646a0746636bf0493fd3cc) fix(bar): update widgets background color properly ### 📊 Changes **2 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/bar.rs` (+7 -0) 📝 `komorebi-bar/src/komorebi.rs` (+4 -0) </details> ### 📄 Description Previously when changing between themes with different backgrounds the widget's background color was not updating because they take the bg color from the `RenderConfig` which was only being updated on `apply_config`, now we also pass the `RenderConfig` to the `apply_theme` function and update it's `background_color` there as well.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:37 +01:00

adam closed this issue

2026-01-05 14:54:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1247