[PR #1186] [MERGED] Feature(wm)/stop ignore restore #1243

New Issue

2026-01-05T14:54:35+01:00

adam commented

2026-01-05 14:54:35 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1186
Author: @alex-ds13
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/18/2024
Merged by: @LGUG2Z

Base: master ← Head: feat(wm)/stop-ignore-restore

📝 Commits (1)

19581d0 feat(wm): allow stopping without restoring windows

📊 Changes

5 files changed (+59 additions, -38 deletions)

View changed files

📝 komorebi/src/core/mod.rs (+1 -0)
📝 komorebi/src/main.rs (+1 -1)
📝 komorebi/src/process_command.rs (+5 -34)
📝 komorebi/src/window_manager.rs (+44 -2)
📝 komorebic/src/main.rs (+8 -1)

📄 Description

This PR creates a new SocketMessage called StopIgnoreRestore which makes komorebi stop without calling window.restore() on all windows. This way every maximized window will stay maximized once you start komorebi again and it is able to use the previous State.

If it fails to restore the previous state you might have to call komorebic restore-windows in case you had hidden windows, for example when when using the window_hiding_behaviour as Hide, or you can simply unminimize them if you were using Cloak or Minimize.

This PR is built on top #1185 so it needs to be merged after that one.

@LGUG2Z I've made this just a draft PR so you can give me your feedback and tell me if you think it's fine to add or if you rather not add it to not increase complexity just to appease the needs of one person (that one person being me 😄). I don't think users can use this to shoot themselves on the foot because even if they are using window_hiding_behaviour as Hide they can always call komorebic restore-windows afterwards if for some reason komorebi fails to load their previous State.
Also this command is mostly intended for developers that are making changes to komorebi code and need to be restarting it a lot of times.
However I totally understand if you think it's better not to add it. In that case I might keep rebasing this commit on top of master just for me... 😄

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1186 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/18/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `feat(wm)/stop-ignore-restore` --- ### 📝 Commits (1) - [`19581d0`](https://github.com/LGUG2Z/komorebi/commit/19581d0eeb36ea120a1c0a55a475203322c28b2d) feat(wm): allow stopping without restoring windows ### 📊 Changes **5 files changed** (+59 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/core/mod.rs` (+1 -0) 📝 `komorebi/src/main.rs` (+1 -1) 📝 `komorebi/src/process_command.rs` (+5 -34) 📝 `komorebi/src/window_manager.rs` (+44 -2) 📝 `komorebic/src/main.rs` (+8 -1) </details> ### 📄 Description This PR creates a new `SocketMessage` called `StopIgnoreRestore` which makes komorebi stop without calling `window.restore()` on all windows. This way every maximized window will stay maximized once you start komorebi again and it is able to use the previous `State`. If it fails to restore the previous state you might have to call `komorebic restore-windows` in case you had hidden windows, for example when when using the `window_hiding_behaviour` as `Hide`, or you can simply unminimize them if you were using `Cloak` or `Minimize`. This PR is built on top #1185 so it needs to be merged after that one. @LGUG2Z I've made this just a draft PR so you can give me your feedback and tell me if you think it's fine to add or if you rather not add it to not increase complexity just to appease the needs of one person (that one person being me 😄). I don't think users can use this to shoot themselves on the foot because even if they are using `window_hiding_behaviour` as `Hide` they can always call `komorebic restore-windows` afterwards if for some reason komorebi fails to load their previous `State`. Also this command is mostly intended for developers that are making changes to komorebi code and need to be restarting it a lot of times. However I totally understand if you think it's better not to add it. In that case I might keep rebasing this commit on top of master just for me... 😄  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:35 +01:00

adam closed this issue

2026-01-05 14:54:35 +01:00

adam referenced this issue

2026-01-05 14:54:42 +01:00

[PR #1243] [CLOSED] feat(date-widget): allow modifiers for strftime integer formatters #1270

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1243