starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1176] [MERGED] feat(bar): add two new display format types #1238

New Issue
Closed
opened 2026-01-05 14:54:34 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1176
Author: @alex-ds13
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/18/2024
Merged by: @LGUG2Z

Base: master ← Head: feature/bar-display-icon-text-on-focused

📝 Commits (1)

  • 0120725 feat(bar): add two new display format types

📊 Changes

2 files changed (+27 additions, -5 deletions)

View changed files

📝 komorebi-bar/src/config.rs (+5 -1)
📝 komorebi-bar/src/komorebi.rs (+22 -4)

📄 Description

This commit adds two new DisplayFormat types:

  • TextAndIconOnSelected: which displays icon and text for the focused element and the other elements only have text.
  • IconAndTextOnSelected: which displays icon and text for the focused element and the other elements only have icon.

Here's a picture that shows both types in action, the workspaces widget has the TextAndIconOnSelected and the focused window has the IconAndTextOnSelected:

image

Currently I've only setup this new types to the workspaces and focused_window widgets. Any other widget that uses DisplayFormat is probably ignoring these new types. If you find there is any other widget that makes sense to handle these types tell me and I can try adding them or they can be added later if someone asks for it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1176 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/18/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `feature/bar-display-icon-text-on-focused` --- ### 📝 Commits (1) - [`0120725`](https://github.com/LGUG2Z/komorebi/commit/01207255bbc41fac4dc51880b126ccf7b3aebef6) feat(bar): add two new display format types ### 📊 Changes **2 files changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/config.rs` (+5 -1) 📝 `komorebi-bar/src/komorebi.rs` (+22 -4) </details> ### 📄 Description This commit adds two new `DisplayFormat` types: - `TextAndIconOnSelected`: which displays icon and text for the focused element and the other elements only have text. - `IconAndTextOnSelected`: which displays icon and text for the focused element and the other elements only have icon. Here's a picture that shows both types in action, the workspaces widget has the `TextAndIconOnSelected` and the focused window has the `IconAndTextOnSelected`: ![image](https://github.com/user-attachments/assets/8ea75afb-8450-4952-82ad-cd2489bbba77) Currently I've only setup this new types to the `workspaces` and `focused_window` widgets. Any other widget that uses `DisplayFormat` is probably ignoring these new types. If you find there is any other widget that makes sense to handle these types tell me and I can try adding them or they can be added later if someone asks for it. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:34 +01:00
adam closed this issue 2026-01-05 14:54:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1238
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?