[PR #1175] [MERGED] Fix: prevent bar from changing mff #1237

New Issue

2026-01-05T14:54:34+01:00

adam commented

2026-01-05 14:54:34 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1175
Author: @alex-ds13
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/bar-changing-mff

📝 Commits (2)

3fee739 feat(client): create send_batch helper
41af031 fix(bar): prevent the bar from changing mff value

📊 Changes

2 files changed (+62 additions, -64 deletions)

View changed files

📝 komorebi-bar/src/komorebi.rs (+48 -64)
📝 komorebi-client/src/lib.rs (+14 -0)

📄 Description

This PR adds a helper function send_batch to komorebi-client that allows sending multiple messages in a batch. 3rd party users of this library could already do this themselves but it is nice to have this helper to simplify it.

Then, on komorebi-bar it makes use of the new send_batch function to batch all the messages in one go when pressing the button to move between workspaces or when moving between stacked windows.
Since we are creating this messages in one go we won't be mistakenly changing the value of mff for the user.
It also only batches the mff messages when the mff value it's true, if it is already false there is no need to be sending those extra messages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1175 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/bar-changing-mff` --- ### 📝 Commits (2) - [`3fee739`](https://github.com/LGUG2Z/komorebi/commit/3fee739318f16bcdd06f35ebcced7fdf29c82c3b) feat(client): create `send_batch` helper - [`41af031`](https://github.com/LGUG2Z/komorebi/commit/41af0311169e1da7a6d80e148b92c2319478c226) fix(bar): prevent the bar from changing mff value ### 📊 Changes **2 files changed** (+62 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/komorebi.rs` (+48 -64) 📝 `komorebi-client/src/lib.rs` (+14 -0) </details> ### 📄 Description This PR adds a helper function `send_batch` to komorebi-client that allows sending multiple messages in a batch. 3rd party users of this library could already do this themselves but it is nice to have this helper to simplify it. Then, on komorebi-bar it makes use of the new `send_batch` function to batch all the messages in one go when pressing the button to move between workspaces or when moving between stacked windows. Since we are creating this messages in one go we won't be mistakenly changing the value of `mff` for the user. It also only batches the `mff` messages when the `mff` value it's true, if it is already false there is no need to be sending those extra messages.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:34 +01:00

adam closed this issue

2026-01-05 14:54:34 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1237

[PR #1175] [MERGED] Fix: prevent bar from changing mff #1237

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #1175] [MERGED] Fix: prevent bar from changing `mff` #1237