mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[PR #1172] [MERGED] fix(borders): properly handle borders ZOrder #1236
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/LGUG2Z/komorebi/pull/1172
Author: @LGUG2Z
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @LGUG2Z
Base:
master← Head:fix/borders_z_order📝 Commits (1)
2523922fix(borders): properly handle borders ZOrder📊 Changes
2 files changed (+59 additions, -49 deletions)
View changed files
📝
komorebi/src/border_manager/border.rs(+12 -0)📝
komorebi/src/border_manager/mod.rs(+47 -49)📄 Description
This commit makes it so a floating window only has the floating border when it is focused, if not it has the
Unfocusedborder. It also makes the 'focused_container' have theUnfocusedborder when it is not the foreground window, for example when we have a floating window focused instead.This commit also changes the border's
window_kindso that the stored borders actually have that value so we can check it later (This value wasn't being updated).This commit also makes it so we properly invalidate the borders in the situations discussed above (for example when changing focus to/from a floating window we need the floating window border to update its ZOrder as well as the previously focused window).
Lastly this commit, changes the
WM_PAINTcode part of the border so that it now sets the position of border so that the border's ZOrder updates to it's tracking window ZOrder.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.