starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1167] [MERGED] fix(border): stop removing borders on wrong monitors #1234

New Issue
Closed
opened 2026-01-05 14:54:33 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1167
Author: @alex-ds13
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/borders-vanishing

📝 Commits (1)

  • bd1ca3d fix(border): stop removing borders on wrong monitors

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 komorebi/src/border_manager/mod.rs (+5 -3)

📄 Description

There is a bug where the border manager is checking if the foreground window is maximized to remove all the borders on that monitor. However this check for is_maximized didn't check if the foreground window in question was on the current monitor being iterated through. So when the foreground (focused) window was maximized, every borders on all monitors were being removed.

This fix makes sure we check if the foreground window is on the monitor being iterated through and only remove the borders on that specific monitor.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1167 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/borders-vanishing` --- ### 📝 Commits (1) - [`bd1ca3d`](https://github.com/LGUG2Z/komorebi/commit/bd1ca3d93eb819d22ae47f33ce2307fb99e5624c) fix(border): stop removing borders on wrong monitors ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/border_manager/mod.rs` (+5 -3) </details> ### 📄 Description There is a bug where the border manager is checking if the foreground window is maximized to remove all the borders on that monitor. However this check for `is_maximized` didn't check if the foreground window in question was on the current monitor being iterated through. So when the foreground (focused) window was maximized, every borders on all monitors were being removed. This fix makes sure we check if the foreground window is on the monitor being iterated through and only remove the borders on that specific monitor. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:33 +01:00
adam closed this issue 2026-01-05 14:54:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?