[PR #1167] [MERGED] fix(border): stop removing borders on wrong monitors #1234

New Issue

2026-01-05T14:54:33+01:00

adam commented

2026-01-05 14:54:33 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1167
Author: @alex-ds13
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/borders-vanishing

📝 Commits (1)

bd1ca3d fix(border): stop removing borders on wrong monitors

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 komorebi/src/border_manager/mod.rs (+5 -3)

📄 Description

There is a bug where the border manager is checking if the foreground window is maximized to remove all the borders on that monitor. However this check for is_maximized didn't check if the foreground window in question was on the current monitor being iterated through. So when the foreground (focused) window was maximized, every borders on all monitors were being removed.

This fix makes sure we check if the foreground window is on the monitor being iterated through and only remove the borders on that specific monitor.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1167 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/borders-vanishing` --- ### 📝 Commits (1) - [`bd1ca3d`](https://github.com/LGUG2Z/komorebi/commit/bd1ca3d93eb819d22ae47f33ce2307fb99e5624c) fix(border): stop removing borders on wrong monitors ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/border_manager/mod.rs` (+5 -3) </details> ### 📄 Description There is a bug where the border manager is checking if the foreground window is maximized to remove all the borders on that monitor. However this check for `is_maximized` didn't check if the foreground window in question was on the current monitor being iterated through. So when the foreground (focused) window was maximized, every borders on all monitors were being removed. This fix makes sure we check if the foreground window is on the monitor being iterated through and only remove the borders on that specific monitor.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:33 +01:00

adam closed this issue

2026-01-05 14:54:33 +01:00

adam referenced this issue

2026-01-05 14:54:42 +01:00

[PR #1234] [MERGED] chore(deps): bump serde_json from 1.0.135 to 1.0.137 #1267

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1234