starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1154] [MERGED] fix(wm): move floats in direction across monitors #1226

New Issue
Closed
opened 2026-01-05 14:54:31 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1154
Author: @alex-ds13
Created: 11/28/2024
Status: ✅ Merged
Merged: 11/30/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/move-in-direction-across-monitors

📝 Commits (2)

  • 8f4bc10 fix(wm): move floats in direction across monitors
  • 3b20e4b refacor(wm): use helper function on move to workspace

📊 Changes

3 files changed (+161 additions, -138 deletions)

View changed files

📝 komorebi/src/monitor.rs (+88 -48)
📝 komorebi/src/process_command.rs (+31 -7)
📝 komorebi/src/window_manager.rs (+42 -83)

📄 Description

This commit fixes an issue where when trying to move floating windows or windows on a floating workspace across boundaries to another monitor using the move_container_in_direction it wouldn't move the floating windows physically, although it moved them internally on komorebi, resulting in weird and wrong behavior.

This commit creates a new method on Monitor to add_container_with_direction which takes a move direction and then uses the same logic that was previously on the move_container_in_direction function.

It changes the move_container_to_monitor function to take an optional move direction which if it is some will have this function call the new method add_container_with_direction instead of just add_container.

Lastly the move_container_in_direction function now when it realizes the move will be across monitors simply calls the move_container_to_monitor with the direction that was initially given to it.

These changes require that all callers of move_container_to_monitor add an direction option, instead of passing None on all of them, a new helper function was created, named direction_from_monitor_idx which calculates the direction a move will have from the currently focused monitor and the target monitor return None if they are the same or returning Some(direction) if not. This way now all commands that call a move across monitor will use the logic to check from the direction if it should add the container on front or end.

With these changes now all the code related to moving a window across monitors using a command should be on one place only making sure that in the future any change required only needs to be done on one place, instead of having to do it on move_container_to_monitor and move_container_in_direction as before!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1154 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 11/28/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/move-in-direction-across-monitors` --- ### 📝 Commits (2) - [`8f4bc10`](https://github.com/LGUG2Z/komorebi/commit/8f4bc101bc746e50348ac109780636be0eb7355a) fix(wm): move floats in direction across monitors - [`3b20e4b`](https://github.com/LGUG2Z/komorebi/commit/3b20e4b2fe99f6c7db52dec6f13f8fd89039daa3) refacor(wm): use helper function on move to workspace ### 📊 Changes **3 files changed** (+161 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/monitor.rs` (+88 -48) 📝 `komorebi/src/process_command.rs` (+31 -7) 📝 `komorebi/src/window_manager.rs` (+42 -83) </details> ### 📄 Description This commit fixes an issue where when trying to move floating windows or windows on a floating workspace across boundaries to another monitor using the `move_container_in_direction` it wouldn't move the floating windows physically, although it moved them internally on komorebi, resulting in weird and wrong behavior. This commit creates a new method on `Monitor` to `add_container_with_direction` which takes a move direction and then uses the same logic that was previously on the `move_container_in_direction` function. It changes the `move_container_to_monitor` function to take an optional move direction which if it is some will have this function call the new method `add_container_with_direction` instead of just `add_container`. Lastly the `move_container_in_direction` function now when it realizes the move will be across monitors simply calls the `move_container_to_monitor` with the direction that was initially given to it. These changes require that all callers of `move_container_to_monitor` add an direction option, instead of passing `None` on all of them, a new helper function was created, named `direction_from_monitor_idx` which calculates the direction a move will have from the currently focused monitor and the target monitor return `None` if they are the same or returning `Some(direction)` if not. This way now all commands that call a move across monitor will use the logic to check from the direction if it should add the container on front or end. With these changes now all the code related to moving a window across monitors using a command should be on one place only making sure that in the future any change required only needs to be done on one place, instead of having to do it on `move_container_to_monitor` and `move_container_in_direction` as before! <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:31 +01:00
adam closed this issue 2026-01-05 14:54:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1226
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?