starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1143] [MERGED] fix(wm): maximized floating windows move across monitors without disappearing #1221

New Issue
Closed
opened 2026-01-05 14:54:30 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1143
Author: @alex-ds13
Created: 11/25/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/move-maximized-floating

📝 Commits (1)

  • 1b49860 fix(wm): maximized floating windows move across monitors without disappearing

📊 Changes

1 file changed (+41 additions, -1 deletions)

View changed files

📝 komorebi/src/window.rs (+41 -1)

📄 Description

When moving maximized floating windows across monitors they were magically disappearing! The window would be on the correct place, with the correct coordinates and size, its styles wouldn't change it would still have the VISIBLE style, however the window was invisible. If we used the system move to try to move it sometimes we would be able to see a bar on the top of the monitor and if we moved the window with the keyboard on the direction of another monitor then the window would start showing up on that monitor... So it was visible on that monitor but not on the one we just moved it into. After some investigation I decided to atribute that behavior to magic, since I couldn't find any other plausible explanation, if someone knows about this please tell me, I too would like to learn the ways of this dark mysteries from the deep of the Windows OS.

On a serious note, this commit creates a workaround for this by simply unmaximazing the window first (it's not restore, it doesn't change the size) then it moves the window (if animations are enabled it proceeds to wait for the animation to finish...), then it maximizes the window again.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1143 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/move-maximized-floating` --- ### 📝 Commits (1) - [`1b49860`](https://github.com/LGUG2Z/komorebi/commit/1b498601b97210284e44fa4250426120f32463d8) fix(wm): maximized floating windows move across monitors without disappearing ### 📊 Changes **1 file changed** (+41 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window.rs` (+41 -1) </details> ### 📄 Description When moving maximized floating windows across monitors they were magically disappearing! The window would be on the correct place, with the correct coordinates and size, its styles wouldn't change it would still have the `VISIBLE` style, however the window was invisible. If we used the system move to try to move it sometimes we would be able to see a bar on the top of the monitor and if we moved the window with the keyboard on the direction of another monitor then the window would start showing up on that monitor... So it was visible on that monitor but not on the one we just moved it into. After some investigation I decided to atribute that behavior to magic, since I couldn't find any other plausible explanation, if someone knows about this please tell me, I too would like to learn the ways of this dark mysteries from the deep of the Windows OS. On a serious note, this commit creates a workaround for this by simply unmaximazing the window first (it's not restore, it doesn't change the size) then it moves the window (if animations are enabled it proceeds to wait for the animation to finish...), then it maximizes the window again. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:30 +01:00
adam closed this issue 2026-01-05 14:54:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?