starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #920] [CLOSED] Fix: cross monitor animation #1140

New Issue
Closed
opened 2026-01-05 14:54:14 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/920
Author: @thearturca
Created: 7/23/2024
Status: ❌ Closed

Base: master ← Head: fix/cross-monitor-animation

📝 Commits (7)

  • dfd6e98 refactor(window): reuse window rect in animate_position method
  • f257873 fix(animation): extend cancelling system to support multiple cancel call
  • 804b038 refactor(animation): remove ANIMATION_TEMPORARILY_DISABLED global vars
  • 53e3526 refactor: apply clippy fixes
  • 84ad947 refactor(animation): remove cancel idx decreasing
  • 9350792 fix(animation): added pending cancel count to track is_cancelled state
  • 18522db fix(animations): change check for existings animation to pending_cancel_count field

📊 Changes

6 files changed (+67 additions, -51 deletions)

View changed files

📝 komorebi/src/animation.rs (+22 -8)
📝 komorebi/src/animation_manager.rs (+36 -7)
📝 komorebi/src/lib.rs (+0 -1)
📝 komorebi/src/process_event.rs (+0 -5)
📝 komorebi/src/window.rs (+9 -12)
📝 komorebi/src/window_manager.rs (+0 -18)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/920 **Author:** [@thearturca](https://github.com/thearturca) **Created:** 7/23/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/cross-monitor-animation` --- ### 📝 Commits (7) - [`dfd6e98`](https://github.com/LGUG2Z/komorebi/commit/dfd6e98e9c0d077b871aaff8175d80aa024eca3c) refactor(window): reuse window rect in `animate_position` method - [`f257873`](https://github.com/LGUG2Z/komorebi/commit/f25787393c6ecd7f48fade369f58fb671e1205b3) fix(animation): extend cancelling system to support multiple cancel call - [`804b038`](https://github.com/LGUG2Z/komorebi/commit/804b0380f709da94d8ec4ae9918dac7db0fd3590) refactor(animation): remove `ANIMATION_TEMPORARILY_DISABLED` global vars - [`53e3526`](https://github.com/LGUG2Z/komorebi/commit/53e3526a3a53efabb57b11b3b72dd7739e3fb0ea) refactor: apply clippy fixes - [`84ad947`](https://github.com/LGUG2Z/komorebi/commit/84ad947e1fb773bf23d770608a72aa26abdbb0b7) refactor(animation): remove cancel idx decreasing - [`9350792`](https://github.com/LGUG2Z/komorebi/commit/935079281a79bacdb8777c0a4606d221329dccc6) fix(animation): added pending cancel count to track `is_cancelled` state - [`18522db`](https://github.com/LGUG2Z/komorebi/commit/18522db9023f33b3ed67f004f60d44e342f4bed9) fix(animations): change check for existings animation to `pending_cancel_count` field ### 📊 Changes **6 files changed** (+67 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/animation.rs` (+22 -8) 📝 `komorebi/src/animation_manager.rs` (+36 -7) 📝 `komorebi/src/lib.rs` (+0 -1) 📝 `komorebi/src/process_event.rs` (+0 -5) 📝 `komorebi/src/window.rs` (+9 -12) 📝 `komorebi/src/window_manager.rs` (+0 -18) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:14 +01:00
adam closed this issue 2026-01-05 14:54:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?