starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #895] [MERGED] Refactoring and fix window shrunk when animate #1130

New Issue
Closed
opened 2026-01-05 14:54:12 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/895
Author: @thearturca
Created: 6/27/2024
Status: ✅ Merged
Merged: 7/4/2024
Merged by: @LGUG2Z

Base: feature/animated-move ← Head: feature/animated-move

📝 Commits (3)

  • 0fe635a refactor(animation): renamed args parameters and variables names
  • 517a0ea refactor(animation): inverse if-statement in window::animate_position
  • dc6884a fix(windows_api): add shadow rect to move_window function call

📊 Changes

3 files changed (+61 additions, -71 deletions)

View changed files

📝 komorebi/src/animation.rs (+15 -13)
📝 komorebi/src/window.rs (+38 -47)
📝 komorebi/src/windows_api.rs (+8 -11)

📄 Description

This pull request fixes bug when window get shrunk during the animation posted by @AmN on discord.
Also pull request renames variables to increase readability.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/895 **Author:** [@thearturca](https://github.com/thearturca) **Created:** 6/27/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `feature/animated-move` ← **Head:** `feature/animated-move` --- ### 📝 Commits (3) - [`0fe635a`](https://github.com/LGUG2Z/komorebi/commit/0fe635a6e725a74f069344c083da1555b0fb13ad) refactor(animation): renamed args parameters and variables names - [`517a0ea`](https://github.com/LGUG2Z/komorebi/commit/517a0ea93e4f780096967aa0f3853b0a0566ea30) refactor(animation): inverse if-statement in `window::animate_position` - [`dc6884a`](https://github.com/LGUG2Z/komorebi/commit/dc6884aebe482f3078727fd1376264b17d28922c) fix(windows_api): add shadow rect to `move_window` function call ### 📊 Changes **3 files changed** (+61 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/animation.rs` (+15 -13) 📝 `komorebi/src/window.rs` (+38 -47) 📝 `komorebi/src/windows_api.rs` (+8 -11) </details> ### 📄 Description This pull request fixes bug when window get shrunk during the animation posted by @AmN on discord. Also pull request renames variables to increase readability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:12 +01:00
adam closed this issue 2026-01-05 14:54:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?