starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #859] [CLOSED] fix parking_lot transitive features conflict #1122

New Issue
Closed
opened 2026-01-05 14:54:11 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/859
Author: @edraze
Created: 5/30/2024
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (4)

  • 458cac9 fix(cli): respect named ws send behaviour
  • 4bcbe91 QUIN-172 fix parking_lot transitive features conflict
  • 334323f fix parking_lot transitive features conflict
  • 41421b3 fix parking_lot transitive features conflict

📊 Changes

2 files changed (+8 additions, -8 deletions)

View changed files

📝 komorebi/Cargo.toml (+2 -2)
📝 komorebi/src/window_manager.rs (+6 -6)

📄 Description

In the case when the komorebi-client is used in one project with some dependency that is transitively used crate parking_lot with feature send_guard, a compilation error occurs because komorebi-client transitively importing parking_lot with feature deadlock_detection and these features are mutually exclusive.

This fix suggests enabling deadlock_detection feature in parking_lot crate only if deadlock_detection enabled for komorebi crate, by default it is disabled so it will solve issue with komorebi-client

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/859 **Author:** [@edraze](https://github.com/edraze) **Created:** 5/30/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`458cac9`](https://github.com/LGUG2Z/komorebi/commit/458cac9ce7a6233ae4e440540515bbc7b92d017e) fix(cli): respect named ws send behaviour - [`4bcbe91`](https://github.com/LGUG2Z/komorebi/commit/4bcbe916f90441433ebbef2c15c6970e9746d4be) QUIN-172 fix parking_lot transitive features conflict - [`334323f`](https://github.com/LGUG2Z/komorebi/commit/334323fcbae748ffe69537d39a6021bd6006627e) fix parking_lot transitive features conflict - [`41421b3`](https://github.com/LGUG2Z/komorebi/commit/41421b30f0a4da75173306b9ee719e603cf461c2) fix parking_lot transitive features conflict ### 📊 Changes **2 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/Cargo.toml` (+2 -2) 📝 `komorebi/src/window_manager.rs` (+6 -6) </details> ### 📄 Description In the case when the `komorebi-client` is used in one project with some dependency that is transitively used crate `parking_lot` with feature `send_guard`, a compilation error occurs because `komorebi-client` transitively importing `parking_lot` with feature `deadlock_detection` and these features are mutually exclusive. This fix suggests enabling `deadlock_detection` feature in `parking_lot` crate only if `deadlock_detection` enabled for `komorebi` crate, by default it is disabled so it will solve issue with `komorebi-client` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:11 +01:00
adam closed this issue 2026-01-05 14:54:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?