starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #800] [MERGED] fix(animation): Move cancel call to Animation struct #1109

New Issue
Closed
opened 2026-01-05 14:54:07 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/800
Author: @thearturca
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/1/2024
Merged by: @LGUG2Z

Base: feature/animated-move ← Head: feature/animated-move

📝 Commits (1)

  • 69d412f fix(animation): Move cancel call to Animation struct

📊 Changes

2 files changed (+4 additions, -5 deletions)

View changed files

📝 komorebi/src/animation.rs (+4 -0)
📝 komorebi/src/window.rs (+0 -5)

📄 Description

Only focused window was cancelling its animation because we call cancel in window::set_position and waiting for its cancelling. And because we waiting for cancelling second window is still moving. Second window will stop moving only after the first window. So I moved cancel call to Animation struct so its happening in its own thread and doesn't block others animation moves and cancels.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/800 **Author:** [@thearturca](https://github.com/thearturca) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/1/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `feature/animated-move` ← **Head:** `feature/animated-move` --- ### 📝 Commits (1) - [`69d412f`](https://github.com/LGUG2Z/komorebi/commit/69d412f47aaa7e29479b2baffc31885ebbe2b1a6) fix(animation): Move cancel call to Animation struct ### 📊 Changes **2 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/animation.rs` (+4 -0) 📝 `komorebi/src/window.rs` (+0 -5) </details> ### 📄 Description Only focused window was cancelling its animation because we call cancel in window::set_position and waiting for its cancelling. And because we waiting for cancelling second window is still moving. Second window will stop moving only after the first window. So I moved `cancel` call to Animation struct so its happening in its own thread and doesn't block others animation moves and cancels. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:07 +01:00
adam closed this issue 2026-01-05 14:54:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1109
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?