starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #798] [MERGED] fix(animation): Fixed cancelling logic #1105

New Issue
Closed
opened 2026-01-05 14:54:07 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/798
Author: @thearturca
Created: 4/30/2024
Status: ✅ Merged
Merged: 4/30/2024
Merged by: @LGUG2Z

Base: feature/animated-move ← Head: feature/animated-move

📝 Commits (2)

  • 4e0cde7 fix(animation): Fixed cancelling logic
  • 1495dd8 refactor(animation): avoid unwrap

📊 Changes

4 files changed (+97 additions, -40 deletions)

View changed files

📝 komorebi/src/animation.rs (+21 -36)
➕ komorebi/src/animation_manager.rs (+68 -0)
📝 komorebi/src/lib.rs (+5 -0)
📝 komorebi/src/window.rs (+3 -4)

📄 Description

Added static animation state manager for tracking "in_progress" and "is_cancelled" states. The idea is not to have states in Animation struct but to keep them in HashMap<hwnd, AnimationState> behind reference (Arc<Mutex<>>). So we each animation frame we have access to state and can cancel animation if we have to.

Need review and testings

@raggi @LGUG2Z

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/798 **Author:** [@thearturca](https://github.com/thearturca) **Created:** 4/30/2024 **Status:** ✅ Merged **Merged:** 4/30/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `feature/animated-move` ← **Head:** `feature/animated-move` --- ### 📝 Commits (2) - [`4e0cde7`](https://github.com/LGUG2Z/komorebi/commit/4e0cde7b458008c77d01e0aebaaf138be11f929b) fix(animation): Fixed cancelling logic - [`1495dd8`](https://github.com/LGUG2Z/komorebi/commit/1495dd84dc69b68501af300b72dee1b30b69ef97) refactor(animation): avoid unwrap ### 📊 Changes **4 files changed** (+97 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/animation.rs` (+21 -36) ➕ `komorebi/src/animation_manager.rs` (+68 -0) 📝 `komorebi/src/lib.rs` (+5 -0) 📝 `komorebi/src/window.rs` (+3 -4) </details> ### 📄 Description Added static animation state manager for tracking "in_progress" and "is_cancelled" states. The idea is not to have states in Animation struct but to keep them in HashMap<hwnd, AnimationState> behind reference (Arc<Mutex<>>). So we each animation frame we have access to state and can cancel animation if we have to. Need review and testings @raggi @LGUG2Z --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:07 +01:00
adam closed this issue 2026-01-05 14:54:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1105
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?