starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #775] [MERGED] fix(docs): correct typo in example config #1096

New Issue
Closed
opened 2026-01-05 14:54:04 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/775
Author: @SVendittelli
Created: 4/22/2024
Status: ✅ Merged
Merged: 4/22/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/border_padding-typo

📝 Commits (1)

  • 1b809db fix(docs): correct typo in example config

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/komorebi.example.json (+1 -1)

📄 Description

The example configuration mistakenly used the key border_padding in the place of border_width. As border_padding does not exist in the spec, modifying its value has no effect.

As this file is used by komorebic quickstart, new users will have this incorrect key in their default configuration. Notably, setting its value to 0 to remove gaps has no effect. The rest of the documentation uses the correct key, so users copying and pasting from that would not encounter the bug.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/775 **Author:** [@SVendittelli](https://github.com/SVendittelli) **Created:** 4/22/2024 **Status:** ✅ Merged **Merged:** 4/22/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/border_padding-typo` --- ### 📝 Commits (1) - [`1b809db`](https://github.com/LGUG2Z/komorebi/commit/1b809dbed43cf73b2c4fb290daf1166831e56f44) fix(docs): correct typo in example config ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/komorebi.example.json` (+1 -1) </details> ### 📄 Description The example configuration mistakenly used the key `border_padding` in the place of `border_width`. As `border_padding` does not exist in the spec, modifying its value has no effect. As this file is used by `komorebic quickstart`, new users will have this incorrect key in their default configuration. Notably, setting its value to `0` to remove gaps has no effect. The rest of the documentation uses the correct key, so users copying and pasting from that would not encounter the bug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:04 +01:00
adam closed this issue 2026-01-05 14:54:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?