starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #754] [MERGED] fix(wm): reduce errors from non-window events #1085

New Issue
Closed
opened 2026-01-05 14:54:02 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/754
Author: @raggi
Created: 4/14/2024
Status: ✅ Merged
Merged: 4/14/2024
Merged by: @raggi

Base: master ← Head: raggi/reduce-errors

📝 Commits (1)

  • 1e37d6d fix(wm): reduce errors from non-window events

📊 Changes

3 files changed (+8 additions, -18 deletions)

View changed files

📝 komorebi/src/process_event.rs (+1 -8)
📝 komorebi/src/stackbar.rs (+3 -9)
📝 komorebi/src/window.rs (+4 -1)

📄 Description

As we have been working down some bugs from earlier changes, we introduced some additional error conditions in the logs. Now that the new focus approach is available, switching the stackbar to that means we can avoid needing to pass down ForceUpdate and FocusChange events for non-windows, which removes many of these cases.

In addition we do a check in should_manage that the target object is actually a window, ignoring the event if it is not.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/754 **Author:** [@raggi](https://github.com/raggi) **Created:** 4/14/2024 **Status:** ✅ Merged **Merged:** 4/14/2024 **Merged by:** [@raggi](https://github.com/raggi) **Base:** `master` ← **Head:** `raggi/reduce-errors` --- ### 📝 Commits (1) - [`1e37d6d`](https://github.com/LGUG2Z/komorebi/commit/1e37d6df8b67cceddddcddcf9ef539abd357c2dd) fix(wm): reduce errors from non-window events ### 📊 Changes **3 files changed** (+8 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_event.rs` (+1 -8) 📝 `komorebi/src/stackbar.rs` (+3 -9) 📝 `komorebi/src/window.rs` (+4 -1) </details> ### 📄 Description As we have been working down some bugs from earlier changes, we introduced some additional error conditions in the logs. Now that the new focus approach is available, switching the stackbar to that means we can avoid needing to pass down ForceUpdate and FocusChange events for non-windows, which removes many of these cases. In addition we do a check in should_manage that the target object is actually a window, ignoring the event if it is not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:02 +01:00
adam closed this issue 2026-01-05 14:54:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1085
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?