starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #745] [MERGED] komorebi: hide the border window when unmanged windows are focused #1084

New Issue
Closed
opened 2026-01-05 14:54:02 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/745
Author: @raggi
Created: 4/13/2024
Status: ✅ Merged
Merged: 4/13/2024
Merged by: @LGUG2Z

Base: master ← Head: raggi/border-window-stuck

📝 Commits (1)

  • 69b9a22 komorebi: hide the border window when unmanged windows are focused

📊 Changes

2 files changed (+23 additions, -7 deletions)

View changed files

📝 komorebi/src/process_event.rs (+20 -0)
📝 komorebi/src/windows_callbacks.rs (+3 -7)

📄 Description

Previously we were dropping events that don't pertain to managed windows, with one exception in should_manage that could probably do with further cleanup (DisplayChange). This first step fixes the latent border window problem, where we would retain a border window when the last managed window was closed and focus transitioned to an unmanaged window.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/745 **Author:** [@raggi](https://github.com/raggi) **Created:** 4/13/2024 **Status:** ✅ Merged **Merged:** 4/13/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `raggi/border-window-stuck` --- ### 📝 Commits (1) - [`69b9a22`](https://github.com/LGUG2Z/komorebi/commit/69b9a2205e5f134a57deeb233b33cb05c3ef8d92) komorebi: hide the border window when unmanged windows are focused ### 📊 Changes **2 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_event.rs` (+20 -0) 📝 `komorebi/src/windows_callbacks.rs` (+3 -7) </details> ### 📄 Description Previously we were dropping events that don't pertain to managed windows, with one exception in should_manage that could probably do with further cleanup (DisplayChange). This first step fixes the latent border window problem, where we would retain a border window when the last managed window was closed and focus transitioned to an unmanaged window. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:02 +01:00
adam closed this issue 2026-01-05 14:54:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?