[PR #744] [MERGED] komorebi: use a new method to focus windows #1082

New Issue

2026-01-05T14:54:02+01:00

adam commented

2026-01-05 14:54:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/744
Author: @raggi
Created: 4/13/2024
Status: ✅ Merged
Merged: 4/14/2024
Merged by: @LGUG2Z

Base: master ← Head: raggi/focus-no-thread

📝 Commits (1)

9b596f3 komorebi: use a new method to focus windows

📊 Changes

4 files changed (+68 additions, -89 deletions)

View changed files

📝 komorebi/src/process_command.rs (+28 -1)
📝 komorebi/src/window.rs (+7 -64)
📝 komorebi/src/window_manager.rs (+1 -4)
📝 komorebi/src/windows_api.rs (+32 -20)

📄 Description

Use the same method as FancyZones to enable setting the foreground window. This makes it possible then to remove the thread attachment behaviors that have a number of other complex side effects, and aren't always allowed. In addition, cleanup old focus/raise methods some, in particular the border window is now explicitly not activated when it is raised, as it should never be activated.

I've also left some breadcrumbs in comments from investigation that I did while doing QA, that highlighted other issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/744 **Author:** [@raggi](https://github.com/raggi) **Created:** 4/13/2024 **Status:** ✅ Merged **Merged:** 4/14/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `raggi/focus-no-thread` --- ### 📝 Commits (1) - [`9b596f3`](https://github.com/LGUG2Z/komorebi/commit/9b596f31e81c76b4847f57253dda34e6ee7e5a86) komorebi: use a new method to focus windows ### 📊 Changes **4 files changed** (+68 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_command.rs` (+28 -1) 📝 `komorebi/src/window.rs` (+7 -64) 📝 `komorebi/src/window_manager.rs` (+1 -4) 📝 `komorebi/src/windows_api.rs` (+32 -20) </details> ### 📄 Description Use the same method as FancyZones to enable setting the foreground window. This makes it possible then to remove the thread attachment behaviors that have a number of other complex side effects, and aren't always allowed. In addition, cleanup old focus/raise methods some, in particular the border window is now explicitly not activated when it is raised, as it should never be activated. I've also left some breadcrumbs in comments from investigation that I did while doing QA, that highlighted other issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:54:02 +01:00

adam closed this issue

2026-01-05 14:54:02 +01:00

adam referenced this issue

2026-01-05 14:54:25 +01:00

[PR #1082] [MERGED] docs(mkdocs): Add note about `Grid` layout not allowing resizing windows #1193

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1082