starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #691] [MERGED] Add new identifier by path #1058

New Issue
Closed
opened 2026-01-05 14:53:57 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/691
Author: @eythaann
Created: 2/28/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @LGUG2Z

Base: master ← Head: new-identifier

📝 Commits (1)

  • 583a045 feat(wm): add path variant to application identifiers

📊 Changes

8 files changed (+68 additions, -4 deletions)

View changed files

📝 komorebi-core/src/config_generation.rs (+1 -1)
📝 komorebi-core/src/lib.rs (+2 -0)
📝 komorebi/src/process_command.rs (+5 -0)
📝 komorebi/src/process_event.rs (+2 -0)
📝 komorebi/src/window.rs (+47 -2)
📝 komorebi/src/window_manager_event.rs (+2 -0)
📝 schema.asc.json (+2 -1)
📝 schema.json (+7 -0)

📄 Description

Problem:

  • Make a unique identifier by app for each exe in a folder sometimes is too much like match all the games that I download from steam as example.

Solution:

  • Allow user define identifiers by path using the contains | startwith strategy will allow user match all apps in a folder. Also this allow user ignore apps with the same identifiers but in different locations as C\programs\app and C\users\name\repository\disk\app good for use different configurations on the installed app and the in development app as example.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/691 **Author:** [@eythaann](https://github.com/eythaann) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `new-identifier` --- ### 📝 Commits (1) - [`583a045`](https://github.com/LGUG2Z/komorebi/commit/583a0459c037d2354e6f9ffb5afd6d699040ad7d) feat(wm): add path variant to application identifiers ### 📊 Changes **8 files changed** (+68 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-core/src/config_generation.rs` (+1 -1) 📝 `komorebi-core/src/lib.rs` (+2 -0) 📝 `komorebi/src/process_command.rs` (+5 -0) 📝 `komorebi/src/process_event.rs` (+2 -0) 📝 `komorebi/src/window.rs` (+47 -2) 📝 `komorebi/src/window_manager_event.rs` (+2 -0) 📝 `schema.asc.json` (+2 -1) 📝 `schema.json` (+7 -0) </details> ### 📄 Description ## Problem: - Make a unique identifier by app for each exe in a folder sometimes is too much like match all the games that I download from steam as example. ## Solution: - Allow user define identifiers by path using the `contains | startwith` strategy will allow user match all apps in a folder. Also this allow user ignore apps with the same identifiers but in different locations as `C\programs\app` and `C\users\name\repository\disk\app` good for use different configurations on the installed app and the in development app as example. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:57 +01:00
adam closed this issue 2026-01-05 14:53:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1058
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?