starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #684] [CLOSED] Add max attemps to retry connection #1054

New Issue
Closed
opened 2026-01-05 14:53:56 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/684
Author: @eythaann
Created: 2/25/2024
Status: ❌ Closed

Base: master ← Head: attemps-to-retry

📝 Commits (1)

  • 12d9193 Add max attemps to retry connection

📊 Changes

1 file changed (+13 additions, -9 deletions)

View changed files

📝 komorebic/src/main.rs (+13 -9)

📄 Description

Problem:
When users runs a shortcut of AHK and komorebi process is not running it start creating komorebic instances indefinitely.

Solution:
Add a max attempts to not wait more than 2s for a response.
Don't try socket connection if komorebi isn't running.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/684 **Author:** [@eythaann](https://github.com/eythaann) **Created:** 2/25/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `attemps-to-retry` --- ### 📝 Commits (1) - [`12d9193`](https://github.com/LGUG2Z/komorebi/commit/12d91938a10396c547feef0b617e968a04b9c59d) Add max attemps to retry connection ### 📊 Changes **1 file changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `komorebic/src/main.rs` (+13 -9) </details> ### 📄 Description Problem: When users runs a shortcut of AHK and komorebi process is not running it start creating komorebic instances indefinitely. Solution: Add a max attempts to not wait more than 2s for a response. Don't try socket connection if komorebi isn't running. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:56 +01:00
adam closed this issue 2026-01-05 14:53:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?