starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #677] [MERGED] fix(komorebi): cleanup window event messaging #1050

New Issue
Closed
opened 2026-01-05 14:53:55 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/677
Author: @raggi
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @LGUG2Z

Base: master ← Head: raggi/event-messaging

📝 Commits (1)

  • 7d4039b fix(komorebi): cleanup window event messaging

📊 Changes

7 files changed (+62 additions, -120 deletions)

View changed files

📝 komorebi/src/hidden.rs (+0 -1)
📝 komorebi/src/main.rs (+4 -10)
📝 komorebi/src/process_event.rs (+1 -1)
📝 komorebi/src/static_config.rs (+1 -1)
📝 komorebi/src/window_manager.rs (+6 -6)
📝 komorebi/src/windows_callbacks.rs (+12 -20)
📝 komorebi/src/winevent_listener.rs (+38 -81)

📄 Description

  • Use a single thread to bind the hook, and then start dispatching.
  • Use a blocking loop for message dispatching.
  • Remove the locks around crossbeam channel, as it's already Send + Sync

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/677 **Author:** [@raggi](https://github.com/raggi) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `raggi/event-messaging` --- ### 📝 Commits (1) - [`7d4039b`](https://github.com/LGUG2Z/komorebi/commit/7d4039b433204318744f90f449e0ad7ca4850ba5) fix(komorebi): cleanup window event messaging ### 📊 Changes **7 files changed** (+62 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/hidden.rs` (+0 -1) 📝 `komorebi/src/main.rs` (+4 -10) 📝 `komorebi/src/process_event.rs` (+1 -1) 📝 `komorebi/src/static_config.rs` (+1 -1) 📝 `komorebi/src/window_manager.rs` (+6 -6) 📝 `komorebi/src/windows_callbacks.rs` (+12 -20) 📝 `komorebi/src/winevent_listener.rs` (+38 -81) </details> ### 📄 Description - Use a single thread to bind the hook, and then start dispatching. - Use a blocking loop for message dispatching. - Remove the locks around crossbeam channel, as it's already Send + Sync --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:55 +01:00
adam closed this issue 2026-01-05 14:53:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1050
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?