[PR #661] [MERGED] fix(cli,tcp): replies are sent on the requesting channel #1038

New Issue

2026-01-05T14:53:53+01:00

adam commented

2026-01-05 14:53:53 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/661
Author: @raggi
Created: 2/11/2024
Status: ✅ Merged
Merged: 2/17/2024
Merged by: @LGUG2Z

Base: master ← Head: raggi/no-client-socket

📝 Commits (1)

1a2abf5 fix(cli,tcp): replies are sent on the requesting channel

📊 Changes

2 files changed (+59 additions, -120 deletions)

View changed files

📝 komorebi/src/process_command.rs (+33 -79)
📝 komorebic/src/main.rs (+26 -41)

📄 Description

Replace the client socket with replies sent on the other side of the querying stream, for both UDS and TCP clients. This has two results: unix socket clients such as komorebic no longer race on the socket bind, fixing the out of order bind error, and the response mixup conditions that could occur. Queries over TCP now receive replies over TCP, rather than replies being sent to a future or in-flight command line client.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/661 **Author:** [@raggi](https://github.com/raggi) **Created:** 2/11/2024 **Status:** ✅ Merged **Merged:** 2/17/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `raggi/no-client-socket` --- ### 📝 Commits (1) - [`1a2abf5`](https://github.com/LGUG2Z/komorebi/commit/1a2abf574d85a92ae4d54042075276daeddd228d) fix(cli,tcp): replies are sent on the requesting channel ### 📊 Changes **2 files changed** (+59 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_command.rs` (+33 -79) 📝 `komorebic/src/main.rs` (+26 -41) </details> ### 📄 Description Replace the client socket with replies sent on the other side of the querying stream, for both UDS and TCP clients. This has two results: unix socket clients such as komorebic no longer race on the socket bind, fixing the out of order bind error, and the response mixup conditions that could occur. Queries over TCP now receive replies over TCP, rather than replies being sent to a future or in-flight command line client. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:53:53 +01:00

adam closed this issue

2026-01-05 14:53:53 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#1038