From eea5a9cb17ffaae4f8e953ecdf342eb426008407 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 11:42:20 -0700 Subject: [PATCH] refactor(kde): workspace.rs matches maximized windows by value, as Windows does Class (a) of the workspace.rs classification (docs/dev/core-model.md section 7): is_focused_window_monocle_or_maximized, contains_window, contains_managed_window and location_from_exe read the maximized window with `if let Some(window) = self.maximized_window` (the Window is Copy) instead of borrowing it, which is the Windows text of those lines. No behaviour change. Verified: KDE cargo test -p komorebi --lib --tests (native, lite env): 630 passed, 0 failed. Not run: doc tests, VM suites. --- komorebi-for-kde/komorebi/src/workspace.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/komorebi-for-kde/komorebi/src/workspace.rs b/komorebi-for-kde/komorebi/src/workspace.rs index 15b3faf2..90403d32 100644 --- a/komorebi-for-kde/komorebi/src/workspace.rs +++ b/komorebi-for-kde/komorebi/src/workspace.rs @@ -909,7 +909,7 @@ impl Workspace { .foreground_window() .and_then(WindowId::to_u32) .ok_or_eyre("no foreground window")?; - if let Some(window) = &self.maximized_window + if let Some(window) = self.maximized_window && window_id == window.id { return Ok(true); @@ -938,7 +938,7 @@ impl Workspace { } } - if let Some(window) = &self.maximized_window + if let Some(window) = self.maximized_window && window_id == window.id { return true; @@ -971,7 +971,7 @@ impl Workspace { } } - if let Some(window) = &self.maximized_window + if let Some(window) = self.maximized_window && let Some(window_exe) = window.exe() && exe == window_exe { @@ -1005,7 +1005,7 @@ impl Workspace { } } - if let Some(window) = &self.maximized_window + if let Some(window) = self.maximized_window && window_id == window.id { return true;