mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-20 07:31:39 +01:00
merge: wip-u-kfm2 + wip-u-settings2 (candidate 3)
Merge of kfm's macOS core migration (wip-u-kfm2 9cb4f2fa) and the settings stack through S3 (wip-u-settings2 696d2929), both on wip-u-integ2. Two files conflicted, both macOS; every hunk is resolved the same way: take kfm's version of the file (its new shapes: komorebi_core Monitor/Workspace, workspace_config and monitor_config as free functions) and re-apply the S3 change to it, because the settings side only touched lines kfm moved. - komorebi-for-mac/komorebi/src/monitor.rs: conflict 1 (imports): kfm's header doc kept, the DEFAULT_CONTAINER_PADDING / DEFAULT_WORKSPACE_PADDING imports dropped (S3). Conflict 2 (std imports): kfm's side (no VecDeque). The four padding reads (the two default fallbacks in the monitor's workspace globals) call crate::settings::container_padding() / workspace_padding(); the now unused Ordering import is removed. - komorebi-for-mac/komorebi/src/static_config.rs: both conflicts are the padding defaults in kfm's free functions (workspace_config, monitor_config): kfm's text kept, the two defaults read from settings. Re-applied S3 in this file: apply_globals applies paddings, aspect ratio, layout_defaults and display_index_preferences as one Handle::update of a SharedDelta; the readers (layout_defaults, aspect ratio, display preferences, paddings) use the accessors; the statics' imports and the now unused AspectRatio imports are removed. komorebi-core and the shared crates read none of the removed statics (grep: only the unrelated DEFAULT_*_PADDING consts in komorebi-config), so no hook is needed. S3 semantics are unchanged from wip-u-settings2 (statics removed, one update per load, reload merges, a few keys reset); the pins are the settings crate's reload.rs and shared tests plus the KDE tests/config.rs. Verified: see the run in the progress log (macOS fake-CC clippy -D warnings -p komorebi-macos --all-targets clean at this revision).
This commit is contained in:
commit
e663e346ba
35 files changed
+556
-337
No files matched your search
@@ -318,3 +318,15 @@ Windows S1/S2, to apply when told (all in the files kfw is changing, so not done
|
||||
4. Gate: Windows clippy (`-D warnings`) and `cargo test -p komorebi --lib`; `tools/e2e-needed` will
|
||||
say YES (the crate is in the closure of `komorebi.exe`) so one e2e run is owed, but behaviour is
|
||||
unchanged.
|
||||
|
||||
## 9. S1, S2 (Windows) and S3 (all three) as landed on `wip-u-settings2`
|
||||
|
||||
Windows S1 and S2 were applied as described in section 8 (package `komorebi-windows`). S3 moved the two
|
||||
default paddings, the floating-window aspect ratio, `layout_defaults` and `display_index_preferences` on
|
||||
all three daemons: statics removed, `apply_globals` applies them with one `Handle::update` of a
|
||||
`SharedDelta` that names only these keys (so the other groups are untouched), the
|
||||
`DisplayIndexPreference` command is one `update`, and readers call the accessors in `settings.rs`
|
||||
(`container_padding()`, `workspace_padding()`, `floating_window_aspect_ratio()`, `layout_defaults()`,
|
||||
`display_index_preferences()`), each a clone from one snapshot. The only BEHAVIOUR is the single
|
||||
publish. Note the KDE integration test harness (`tests/config.rs`) now resets the paddings through
|
||||
`settings()`; it is the oracle that loads configurations over a fake desktop.
|
||||
Reference in new issue
Block a user