mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-16 13:51:19 +01:00
feat(wm): fullscreen is left alone
A fullscreen window covers its monitor on purpose. Moving it would take it out of fullscreen, or be ignored, so Window::set_position does nothing for a fullscreen window, and every move the window manager makes goes through it. The bridge reports KWin's fullScreenChanged as a fullscreen event, and the table keeps what it says, which is what the window manager asks. The window stays in its container, and the others are tiled as if it were not fullscreen. When it comes back from fullscreen, KWin gives it the frame it had before, which may not be its tile any more, so the workspace is tiled again. Section E of the features suite checks it in a real Plasma session: a fullscreen window covers the monitor, a window that opens does not take it out of fullscreen, and it is in a tile that overlaps no other when it comes back.
This commit is contained in:
1 parent
d6ad3b4292
commit
e563988258
21 files changed
+586
-38
No files matched your search
@@ -658,3 +658,16 @@ the layout as `toggle-maximize` makes a window leave it, and what is asked of th
|
||||
nothing "until it is restored, by `toggle-maximize` or by the user" (the comment in
|
||||
`process_command`). Because the report is the same either way, one comparison serves both: a window
|
||||
that is, or is not, already the workspace's maximized window changes nothing.
|
||||
|
||||
## Why does komorebi leave a fullscreen window alone, and tile the workspace when it comes back?
|
||||
|
||||
Because the window covers the monitor on purpose. The comment in
|
||||
[`Window::set_position`](../../komorebi/src/window.rs) says that "moving it would take it out of
|
||||
fullscreen, or be ignored", and that "it goes back to its tile when it leaves fullscreen". The
|
||||
window stays in its container, so the other windows are tiled as if it were not fullscreen, and
|
||||
every move the window manager makes goes through `set_position`, which is where the window is
|
||||
skipped. When the window comes back, "KWin gives it the frame it had before, which may not be the
|
||||
tile it has now" (the comment in `handle_event`), so the workspace is tiled again. The bridge's
|
||||
second request for a position gives up after three tries for the same reason: so that a window that
|
||||
cannot go where it was asked, "a fullscreen one, say", is left alone rather than chased (the comment
|
||||
on `settle` in [`bridge.js`](../../komorebi/src/kwin/bridge.js)).
|
||||
Reference in new issue
Block a user