mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-20 15:41:38 +01:00
feat(wm): a window the user maximizes
KWin maximizes a window for the user as well as for komorebi: the title bar, a double click and a shortcut do it, and nobody asks the window manager. A window that stayed a tile would be asked to move at the next retile, so komorebi has to know. The bridge reports KWin's maximizedChanged as a maximized event, true only when the window is maximized both ways. The table turns it into a MaximizeChange, and adopt_maximize_change takes the window out of the layout as toggle-maximize does, or, when the user restores it, puts it back in a container of its own at the index it came from. A window that is already maximized when komorebi starts, or that opens maximized, is the workspace's maximized window from the start. komorebi's own maximize is reported too and finds the workspace as it left it, so it changes nothing. While a window is maximized, what is asked of the layout does nothing, by the same rule as for toggle-maximize. A maximized window of a monitor that is unplugged goes to the monitor that is left and stays maximized: evacuate_monitor makes it the maximized window of the workspace it goes to, and the maximized window that workspace had goes back to its tile. Until now it came back as a tile. vm-user-maximize maximizes windows with kdotool in a headless KWin, and checks the daemon's state, the frames, that the layout commands do nothing, and that toggle-maximize and the user's restore both put the window back in its tile.
This commit is contained in:
1 parent
0210ec285a
commit
d6ad3b4292
31 files changed
+1246
-88
No files matched your search
@@ -644,3 +644,17 @@ Because after the screen is unlocked the window that is active again is not alwa
|
||||
and komorebi's idea of the focus would stay the one it had. Once a second the bridge compares the
|
||||
window KWin has active with the one it last announced, and announces the active one when they
|
||||
differ. It costs a comparison of two ids a second.
|
||||
|
||||
## Why is a window the user maximizes treated like one komorebi maximized?
|
||||
|
||||
Because the compositor reports both the same way, and komorebi has to follow it. The comment on the
|
||||
`MaximizeChange` event says that komorebi's own `toggle-maximize` "does this too and finds the window
|
||||
already as it asked, but the user's title bar does it without komorebi's knowing". A window that
|
||||
stayed a tile would be asked to move at the next retile: the code that reads the windows that are
|
||||
open when komorebi starts says a window that is already maximized is "the maximized window, not a tile
|
||||
that would be asked to leave the maximized state". So
|
||||
[`WindowManager::adopt_maximize_change`](../../komorebi/src/window_manager.rs) takes the window out of
|
||||
the layout as `toggle-maximize` makes a window leave it, and what is asked of the layout does
|
||||
nothing "until it is restored, by `toggle-maximize` or by the user" (the comment in
|
||||
`process_command`). Because the report is the same either way, one comparison serves both: a window
|
||||
that is, or is not, already the workspace's maximized window changes nothing.
|
||||
Reference in new issue
Block a user