mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-22 08:31:50 +01:00
feat(wm): resize by dragging an edge
Dragging an edge or a corner of a tiled window resizes its tile when the user lets go: each edge of the tile moves by what the pointer moved it, the neighbors give up or take the room, and the window is put on its tile. A drag is measured from the frame the window had when the user took hold of it, edge by edge, and resizes the container of the window that was dragged, through resize_window and so within its bound (no tile below a tenth of the work area). KWin reports the window's frame all through a drag, so the table keeps the frame of the start for the window manager (Backend::drag_origin). At the end the frame can still be short of the pointer, because KWin changes it once the client has drawn at the new size; the bridge keeps the frame the last step of the drag asked for and sends it as `requested`, and the end of a resize is that frame. The window of a stack has the tile of the stack; a floating window and the window of a monocle have none, and are left as the user made them. The end of a resize is read apart from the window's frame, and that deviates from the spike. The spike stores the frame the last step asked for as the window's own frame, where the next frame event replaces it. KWin sends one a millisecond after the end, with what the client has drawn so far (660 pixels of the 672 asked for), and a window manager that is busy with an earlier event reads that frame when it handles the end: a tile moved by 60 pixels for a drag of 72. Here the table keeps the end apart (Table::drag_end, and Backend::drag_end for the window manager, None by default), ResizeEnd reads it as ResizeStart reads drag_origin, and the window's frame stays the one KWin reports. A resize that sent no step ends at the frame. The order that failed is a test of the KWin backend with the real table and window manager, in which the tile took 140 of the 200 pixels without this. komorebi-layouts at the pinned revision has the fix of LGUG2Z/komorebi#1765, so nothing is vendored, and docs/drag-resize.md says what a drag does and why each rule is there. vm-drag-resize drags edges and corners of three tiles with the pointer that the session node has (komorebi_vm.Pointer), whose moves are batched in the guest. The suite drags against the daemon the module starts with the session, and reads the drags that daemon has handled from the unit's journal. vm-drag-resize waits, for 30 seconds at most, for the daemon to have the room KWin takes for the panel before it opens the windows (Kde.wait_for_panel_room). The panel moved every tile in the middle of a case that began before the daemon learned of it, which showed as an edge that was not dragged. It is a wait and not a check, since a session that is too slow may never take the room.
This commit is contained in:
1 parent
f5933d1ff8
commit
af560f47d7
23 files changed
+1442
-47
No files matched your search
@@ -542,3 +542,25 @@ backend asks it through the held call, and returns the last position the table h
|
||||
answer comes within 250 ms. The end of a drag is the moment the window manager asks, and the
|
||||
event that reports it brings the position of the pointer with it, so the last position the
|
||||
table has is the one that counts.
|
||||
|
||||
## Why is a drag of an edge measured from where the window was when it began?
|
||||
|
||||
A window is not always on its tile. A client that sizes itself to a grid, such as a terminal that
|
||||
keeps to whole cells of its font, is a few pixels short of it, and a window with a minimum size
|
||||
can be larger. Measured against the tile, every drag of such a window would look as if it had
|
||||
moved the other edges too, and they would be resized as well. The frame the window had when the
|
||||
drag began is what the user had under the pointer, so the drag is measured from it. KWin reports
|
||||
the window's frame all through a drag, so the table keeps the frame of the start apart from it,
|
||||
and the window manager reads that one when it handles the start.
|
||||
|
||||
## Why is the end of a resize the frame the user asked for and not the window's frame?
|
||||
|
||||
KWin changes the window's frame only once the client has drawn at the new size, so when the user
|
||||
lets go the frame can be short of where they took the edge
|
||||
([PLATFORM.md](PLATFORM.md#how-clients-answer-a-frame)). The frame the last step of the drag asked
|
||||
for is where the user took it. The table keeps it apart from the window's frame, because the window
|
||||
manager does not handle the end of the drag at once: it may be busy with an earlier event, and the
|
||||
frame event KWin sends a millisecond after the end changes the frame in the table before the window
|
||||
manager reads it. The end of the drag has to survive that, so it is not the window's frame. The
|
||||
frame events go on updating the window's frame, and the retile that ends the drag puts the window on
|
||||
its tile. A move changes no size, so the end of a move is the frame.
|
||||
Reference in new issue
Block a user