From ad2281de199f55d3293fd87b9d41371e3650059a Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Fri, 30 Oct 2026 21:09:20 -0700 Subject: [PATCH] refactor(kde): converge animation/prefix.rs to the shared AnimationPrefix KDE's AnimationPrefix gains the Transparency and Workspace variants, so that all three trees share the union {movement, transparency, workspace} (D15/D16). KDE only ever uses Movement; the new variants are accepted in the configuration and on the command line and ignored by the KDE daemon, as macOS ignores Transparency today. Intentional schema change, regenerated with komorebic static-config-schema: in komorebi-for-kde/schema.json the per-prefix animation settings (enabled, duration, style) change from properties {movement} with additionalProperties false to additionalProperties of the value type (the same shape as the Windows schema). The animation CLI docs list the three values. Verified: cargo test -p komorebi --lib --test schemas --test animation in komorebi-for-kde: 305 + 5 + 1 passed, 0 failed. --- .../docs/cli/animation-duration.md | 2 +- komorebi-for-kde/docs/cli/animation-style.md | 2 +- komorebi-for-kde/docs/cli/animation.md | 2 +- .../komorebi/src/animation/prefix.rs | 3 ++ komorebi-for-kde/schema.json | 31 +++++++------------ 5 files changed, 17 insertions(+), 23 deletions(-) diff --git a/komorebi-for-kde/docs/cli/animation-duration.md b/komorebi-for-kde/docs/cli/animation-duration.md index d7dcd669..89f14c07 100644 --- a/komorebi-for-kde/docs/cli/animation-duration.md +++ b/komorebi-for-kde/docs/cli/animation-duration.md @@ -11,7 +11,7 @@ Options: -a, --animation-type Animation type to apply the duration to. If not specified, sets global duration - [possible values: movement] + [possible values: movement, transparency, workspace] -h, --help Print help diff --git a/komorebi-for-kde/docs/cli/animation-style.md b/komorebi-for-kde/docs/cli/animation-style.md index 62065a3f..d7e42365 100644 --- a/komorebi-for-kde/docs/cli/animation-style.md +++ b/komorebi-for-kde/docs/cli/animation-style.md @@ -45,7 +45,7 @@ Options: -a, --animation-type Animation type to apply the style to. If not specified, sets global style - [possible values: movement] + [possible values: movement, transparency, workspace] -h, --help Print help (see a summary with '-h') diff --git a/komorebi-for-kde/docs/cli/animation.md b/komorebi-for-kde/docs/cli/animation.md index b5c7ad35..ae1ef2f7 100644 --- a/komorebi-for-kde/docs/cli/animation.md +++ b/komorebi-for-kde/docs/cli/animation.md @@ -11,7 +11,7 @@ Options: -a, --animation-type Animation type to apply the state to. If not specified, sets global state - [possible values: movement] + [possible values: movement, transparency, workspace] -h, --help Print help diff --git a/komorebi-for-kde/komorebi/src/animation/prefix.rs b/komorebi-for-kde/komorebi/src/animation/prefix.rs index 3a4721ed..e9d0eedb 100644 --- a/komorebi-for-kde/komorebi/src/animation/prefix.rs +++ b/komorebi-for-kde/komorebi/src/animation/prefix.rs @@ -15,6 +15,9 @@ use strum::EnumString; #[serde(rename_all = "snake_case")] pub enum AnimationPrefix { Movement, + Transparency, + /// A workspace sliding in and out of a monitor when it is switched to + Workspace, } pub fn new_animation_key(prefix: AnimationPrefix, key: String) -> String { diff --git a/komorebi-for-kde/schema.json b/komorebi-for-kde/schema.json index 4a209b06..015f16d2 100644 --- a/komorebi-for-kde/schema.json +++ b/komorebi-for-kde/schema.json @@ -3316,12 +3316,9 @@ { "description": "Animation configuration prefixed for a specific animation kind", "type": "object", - "properties": { - "movement": { - "type": "boolean" - } - }, - "additionalProperties": false + "additionalProperties": { + "type": "boolean" + } }, { "description": "Animation configuration for all animation kinds", @@ -3335,14 +3332,11 @@ { "description": "Animation configuration prefixed for a specific animation kind", "type": "object", - "properties": { - "movement": { - "type": "integer", - "format": "uint64", - "minimum": 0 - } - }, - "additionalProperties": false + "additionalProperties": { + "type": "integer", + "format": "uint64", + "minimum": 0 + } }, { "description": "Animation configuration for all animation kinds", @@ -3358,12 +3352,9 @@ { "description": "Animation configuration prefixed for a specific animation kind", "type": "object", - "properties": { - "movement": { - "$ref": "#/$defs/AnimationStyle" - } - }, - "additionalProperties": false + "additionalProperties": { + "$ref": "#/$defs/AnimationStyle" + } }, { "description": "Animation configuration for all animation kinds",