From a57ca82f0c0f917a978337f6c721ee2da3a61931 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Fri, 30 Oct 2026 20:41:02 -0700 Subject: [PATCH] fix(nix): do not require dirtyRev in the root flake A path flake (a jj workspace without .git) has neither rev nor dirtyRev, so the commit stamp default in mkKomorebiPackages failed to evaluate. It now falls back to "unknown", as the nested flakes do. Verified: nix eval --raw .#checks.x86_64-linux.komorebi-workspace-clippy.drvPath now prints z9nb5j12qlfp1j8d71ykp9qnafk553ra-komorebi-workspace-clippy-0.1.0.drv (it failed before); .#packages.x86_64-linux.default.drvPath is cq0i40300hgsm0ih2llcdjpkcg9sfqaf-komorebi-workspace-0.1.0.drv. Neither was built. --- flake.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flake.nix b/flake.nix index 058cbda2..024028b4 100644 --- a/flake.nix +++ b/flake.nix @@ -173,7 +173,7 @@ windowsSdk, # the commit stamped into the binaries; a build for the e2e guest # gives a constant one, so that a new commit does not rebuild it - commit ? self.rev or (pkgs.lib.removeSuffix "-dirty" self.dirtyRev), + commit ? self.rev or (pkgs.lib.removeSuffix "-dirty" (self.dirtyRev or "unknown")), }: let # toolchain with windows msvc target