From 9e39fcbbf41d7c15d582175f1336ac58fecec73f Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Fri, 30 Oct 2026 22:02:37 -0700 Subject: [PATCH] build(transport): add the komorebi-transport crate with the pause filter A new platform-neutral crate, crates/komorebi-transport (edition 2024, member of the root workspace), that will hold the command transport shared by the three daemons (D23/D24). It starts with allowed_while_paused(&SocketMessage) -> bool: the four messages (TogglePause, State, GlobalState, Stop) a daemon still handles while it is paused. It is a free function and not a method of the protocol enum because it is daemon policy, not wire format. Nothing calls it yet. A unit test lists the four and checks that other messages are refused. Verified: cargo test -p komorebi-transport: 1 passed, 0 failed (native, tier 1). The tree gates run in the revisions that adopt it. --- Cargo.lock | 7 +++++ Cargo.toml | 1 + crates/komorebi-transport/Cargo.toml | 8 +++++ crates/komorebi-transport/src/lib.rs | 9 ++++++ crates/komorebi-transport/src/pause.rs | 42 ++++++++++++++++++++++++++ 5 files changed, 67 insertions(+) create mode 100644 crates/komorebi-transport/Cargo.toml create mode 100644 crates/komorebi-transport/src/lib.rs create mode 100644 crates/komorebi-transport/src/pause.rs diff --git a/Cargo.lock b/Cargo.lock index e11eae46..f131762f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3530,6 +3530,13 @@ dependencies = [ "strum", ] +[[package]] +name = "komorebi-transport" +version = "0.1.42" +dependencies = [ + "komorebi-protocol", +] + [[package]] name = "komorebic" version = "0.1.42" diff --git a/Cargo.toml b/Cargo.toml index 744d315b..e7eb78e1 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -13,6 +13,7 @@ members = [ "komorebi-bar", "komorebi-themes", "crates/komorebi-protocol", + "crates/komorebi-transport", "komorebi-shortcuts", "e2e/guest/agent", "e2e/guest/testwin", diff --git a/crates/komorebi-transport/Cargo.toml b/crates/komorebi-transport/Cargo.toml new file mode 100644 index 00000000..b816430f --- /dev/null +++ b/crates/komorebi-transport/Cargo.toml @@ -0,0 +1,8 @@ +[package] +name = "komorebi-transport" +version = "0.1.42" +description = "The command transport shared by every komorebi daemon: the pause filter, the command listener and the subscriber registry" +edition = "2024" + +[dependencies] +komorebi-protocol = { path = "../komorebi-protocol", default-features = false } diff --git a/crates/komorebi-transport/src/lib.rs b/crates/komorebi-transport/src/lib.rs new file mode 100644 index 00000000..06138bf7 --- /dev/null +++ b/crates/komorebi-transport/src/lib.rs @@ -0,0 +1,9 @@ +//! The command transport shared by every komorebi daemon. +//! +//! The crate holds no window-manager code: the daemons plug their own window manager in through +//! small traits. +#![warn(clippy::all)] + +mod pause; + +pub use pause::allowed_while_paused; diff --git a/crates/komorebi-transport/src/pause.rs b/crates/komorebi-transport/src/pause.rs new file mode 100644 index 00000000..d07ce5ef --- /dev/null +++ b/crates/komorebi-transport/src/pause.rs @@ -0,0 +1,42 @@ +use komorebi_protocol::message::SocketMessage; + +/// Whether a daemon that is paused still handles `message` +/// +/// Only `TogglePause` (to be able to resume), `State`, `GlobalState` and `Stop` are. This is +/// daemon policy and not part of the wire format, which is why it is a function here and not a +/// method of [`SocketMessage`]. +#[must_use] +pub fn allowed_while_paused(message: &SocketMessage) -> bool { + matches!( + message, + SocketMessage::TogglePause + | SocketMessage::State + | SocketMessage::GlobalState + | SocketMessage::Stop + ) +} + +#[cfg(test)] +mod tests { + use super::*; + + #[test] + fn only_the_four_messages_are_allowed_while_paused() { + for message in [ + SocketMessage::TogglePause, + SocketMessage::State, + SocketMessage::GlobalState, + SocketMessage::Stop, + ] { + assert!(allowed_while_paused(&message), "{message}"); + } + + for message in [ + SocketMessage::Retile, + SocketMessage::UnmanageFocusedWindow, + SocketMessage::ReloadConfiguration, + ] { + assert!(!allowed_while_paused(&message), "{message}"); + } + } +}