mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-20 23:51:40 +01:00
feat(gui): one window for recording and reviewing
The recorder is now the pinned first tab (Record, not closable, with a REC marker while recording) of the viewer window; sessions follow as tabs. There is one process and one window: komorebi-recorder, gui and view all claim the same socket, and a second launch forwards (gui shows the Record tab, view opens tabs) and exits. The request protocol gains an optional "tab" field; old requests still parse. gui takes the record options (they only seed the window that is started) and --new-window. The window starts compact (420x380, always on top, Record tab only) when launched plainly and full size for view; opening any session expands it, and Compact / Expand is remembered in the prefs. RecorderApp::poll runs on every frame whichever tab is showing, so recordings continue and finalize while another tab is looked at. Cmd/Ctrl+0 shows the Record tab; Cmd/Ctrl+W on it does nothing; closing the last session tab returns to Record. KOMOREBI_RECORDER_PREFS_DIR and KOMOREBI_RECORDER_NO_IGNORE_RULE let tests and end-to-end runs avoid the real prefs and the real komorebi. The macOS/unix cfg branches (hidden title bar spacing) mirror the existing tested patterns and could not be compiled on the Windows machine this was written on.
This commit is contained in:
1 parent
72d600c8f6
commit
8e454e1e03
19 files changed
+1603
-571
No files matched your search
+11
-4
@@ -83,13 +83,20 @@ recorded in the manifest, and everything that reads a session asks the manifest.
|
||||
|
||||
## Why can a bug only be marked in the viewer?
|
||||
|
||||
The recorder window has no button for marking a bug, and the viewer has one. I found it confusing to have two places to do
|
||||
the same thing, so a bug is marked in the viewer only. `komorebi-recorder annotate` writes the same annotations for a
|
||||
The Record tab has no button for marking a bug, and a session's tab has one. I found it confusing to have two places to do
|
||||
the same thing, so a bug is marked in a session's tab only. `komorebi-recorder annotate` writes the same annotations for a
|
||||
script or an agent that has no window.
|
||||
|
||||
## Why is the recorder window untitled?
|
||||
## Why is there one window?
|
||||
|
||||
komorebi does not manage windows with an empty title, so a borderless untitled window is never tiled: opening the recorder
|
||||
Recording and reviewing used to be two windows, and the recorder's buttons for opening a recording started the other one.
|
||||
Now the recorder is the pinned first tab of the one window and each recording is a tab after it, so there is one thing to
|
||||
keep out of the video and out of komorebi's layout. It starts small, always on top, with only the Record tab, which is what
|
||||
the old recorder window was for, and grows when a recording is opened.
|
||||
|
||||
## Why is the window untitled?
|
||||
|
||||
komorebi does not manage windows with an empty title, so an untitled window is never tiled: opening the recorder
|
||||
does not move the layout of the machine whose bug is being recorded.
|
||||
|
||||
## Why is ffmpeg not part of the program?
|
||||
|
||||
Reference in new issue
Block a user