mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-19 15:18:40 +01:00
feat(icon): a watermelon for every window
The recorder window and the viewer carry an icon of their own: a slice of watermelon, drawn as komorebi-recorder/assets/watermelon.svg. `just icon` (assets/generate.py, with resvg from the devShell) renders the PNG the windows set and the ICO that Windows embeds. Until now eframe's default egui icon showed. macOS: eframe sets the PNG as the Dock icon while a window is open. The program is a bare executable and not an app bundle, so Finder is unchanged. Windows: eframe sets the same PNG as the window and taskbar icon. build.rs compiles the ICO into both executables with embed-resource (rc.exe on Windows, llvm-rc when cross-building from a Mac), and the installer shows it in Apps & features through ARPPRODUCTICON. The taskbar, Explorer and the installer have not been looked at on Windows: W4 and W5 in docs/dev/windows-checkpoints.md now say what to check. embed-resource adds seven crates to the lockfile and moves toml_datetime and toml_parser up by a patch release.
This commit is contained in:
1 parent
df4ab2d2a5
commit
8a203f0da7
19 files changed
+335
-17
No files matched your search
@@ -117,6 +117,7 @@ The recorder window and the viewer must not be in the video they are recording,
|
||||
|---|---|---|
|
||||
| left out of the video | by name: every process called `komorebi-recorder` is excluded from the capture | each window asks to be left out of captures with `WDA_EXCLUDEFROMCAPTURE` (Windows 10 version 2004 and later) |
|
||||
| left alone by komorebi | the windows have no title, which komorebi does not manage | the same, and `KOMOREBI_RECORDER_PROBE_WINDOW=1` makes a window ask komorebi whether it would manage it and write the answer to `komorebi-recorder-window-probe.txt` in the temp directory |
|
||||
| icon | a slice of watermelon, which the Dock shows while a window is open (eframe sets it as the application's icon image). The program is a bare executable and not an app bundle, so Finder gives the file the generic executable icon | the same picture as the window and taskbar icon while a window is open, and compiled into both executables as a resource, which is what Explorer shows for the files; the installer shows it beside the program in Apps & features |
|
||||
| executables | `komorebi-recorder` | `komorebi-recorder.exe` (console: run commands with this one) and `komorebi-recorder-gui.exe` (no console window) |
|
||||
|
||||
## Degraded modes
|
||||
|
||||
@@ -179,6 +179,7 @@ Status: can be run once W1 shows capture works.
|
||||
1. Start komorebi, then open the viewer on a Windows session: `komorebi-recorder-gui.exe view
|
||||
C:\temp\w2`. It should open floating (not tiled into your layout) and be usable: moving, resizing,
|
||||
minimizing and closing it. If komorebi tiles it, say so.
|
||||
Its taskbar button and Alt+Tab entry should show the watermelon icon.
|
||||
2. Ask komorebi what it thinks of it. Set `KOMOREBI_RECORDER_PROBE_WINDOW=1` before starting the
|
||||
viewer (or the recorder window), wait a few seconds, and send back
|
||||
`%TEMP%\komorebi-recorder-window-probe.txt`.
|
||||
@@ -204,6 +205,7 @@ warn on the first run.
|
||||
|
||||
That it runs proves the `PATH` entry. `Program Files\komorebi-recorder\bin` should hold `komorebi-recorder.exe` and
|
||||
`komorebi-recorder-gui.exe`.
|
||||
In Explorer both executables should show the watermelon icon, and so should the entry in Apps & features.
|
||||
|
||||
2. Install a second build over it, such as the next nightly. It should upgrade in place: one entry in Apps & features,
|
||||
not two.
|
||||
|
||||
Reference in new issue
Block a user