mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-19 07:08:48 +01:00
feat(kwin): workspaces are KWin's own desktops
komorebi's workspaces exist on Windows and macOS because neither has a virtual desktop API: switching hides every window of the workspace being left. KWin has virtual desktops, per output since 6.8, so here workspace i is KWin's desktop i on every monitor, and each monitor shows one. KWin shows, hides and focuses the windows of a desktop; komorebi asks for a switch, puts a window on a desktop, and follows what anything else does. The Backend gets the workspace methods (ensure_workspaces, switch_workspace, set_window_workspace, window_workspace, current_workspaces), and the fake its desktops. The bridge reports the desktops, the desktop each output shows and a window's desktops, and carries out output_desktop and desktop commands, typed and tested with the fixtures like the rest. The table turns a switch or a move komorebi did not make into a WorkspaceChange or a WorkspaceMove, and records its own when it sends them, so that KWin's report of those raises nothing. The window manager follows a switch with no command in reply (adopt_workspace_change), puts windows on their desktops before a desktop is shown (focusing a window first would take the monitor back), and loads the windows open at startup onto the workspace of their desktop. Per-output desktops are a kwinrc setting that is off by default, and kwriteconfig6 was not on the PATH of the user service in a live session, so komorebi edits kwinrc itself (kwin::kwinrc) and puts the user's value back when it stops, also after a crash. focus-workspace, move-to-workspace and send-to-workspace come with this commit, since the tests of switching and moving, and vm-workspace-switch, need them; the named and cycling workspace commands follow. vm-workspace-switch runs the daemon against a real KWin; vm-kwin-contract checks what komorebi relies on from KWin's per-output desktops, on a headless KWin with two outputs and no komorebi.
This commit is contained in:
1 parent
1b10611022
commit
62e37e44cf
38 files changed
+3522
-77
No files matched your search
@@ -223,3 +223,39 @@ to put a window for a second, and sets the position again when the window's fram
|
||||
another one in that time ([PLATFORM.md](PLATFORM.md#how-clients-answer-a-frame)). Three tries
|
||||
at most keep it from chasing a window that cannot go where it was asked, such as a fullscreen
|
||||
one.
|
||||
|
||||
## Why are komorebi's workspaces KWin's virtual desktops?
|
||||
|
||||
Because KWin has virtual desktops, per output since KWin 6.8, and Windows and macOS have no API
|
||||
for them. komorebi's own workspaces exist there for that reason: switching workspace hides
|
||||
every window of the workspace being left and restores the windows of the one being entered. On
|
||||
KDE that is what KWin does with its desktops, and native behavior is preferred over a
|
||||
workaround (see [What is komorebi for KDE the port of?](#what-is-komorebi-for-kde-the-port-of)):
|
||||
workspace `i` is desktop `i` on every monitor, and each monitor shows one at a time.
|
||||
|
||||
The spikes measured what KWin does with per-output desktops on a headless KWin with two
|
||||
outputs: showing a desktop on one output left the other output's alone; KWin gave the focus to
|
||||
a window of the desktop it switched to, by itself; and activating a window on another desktop
|
||||
of its output (an application raising itself) made KWin switch that output to the window's
|
||||
desktop and focus the window, by itself. So komorebi asks for a switch and follows the ones it
|
||||
did not ask for, with no command in reply. A first attempt in which komorebi hid the windows
|
||||
itself switched between two workspaces about 280 times a second after an application raised a
|
||||
window of another workspace: KWin delivered focus events it had generated before it carried
|
||||
out komorebi's commands, and komorebi took each for a new request. With KWin's desktops there
|
||||
is nothing to debounce, since komorebi answers a switch with nothing.
|
||||
|
||||
The costs: desktops are global, so every monitor has as many as the monitor with the most
|
||||
workspaces, with one name each, and they show in the pager and the overview. A window komorebi
|
||||
does not manage (a dialog, say) belongs to the desktop it opened on and goes out of view with
|
||||
it. The desktops komorebi created stay when it stops: by then they are the user's desktops.
|
||||
|
||||
## Why does komorebi edit `kwinrc` itself?
|
||||
|
||||
Because per-output virtual desktops are off by default, they are a setting in the user's
|
||||
`kwinrc`, and the program that would set it cannot be counted on. KDE's `kwriteconfig6` was not
|
||||
on the PATH of komorebi's user service in the first live run in a Plasma session, and
|
||||
per-output desktops stayed off; `kreadconfig6` is not always installed either. The file is
|
||||
plain ini, which komorebi changes line by line, and asks KWin to reload its configuration.
|
||||
It is the user's setting, so the value komorebi found is kept in a backup file and put back
|
||||
when komorebi stops; a backup a crash left behind keeps the value from before the first run,
|
||||
and the next run puts it back.
|
||||
Reference in new issue
Block a user