From 573f48ad7881cae7feddfde60cc0e019f4736f39 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Fri, 30 Oct 2026 21:30:38 -0700 Subject: [PATCH] refactor(kde): carry DebugWindow as i64 DebugWindow(i64) as in the unified SocketMessage (D15). An id outside u32 range, which KDE used to refuse at parse time, now parses and is answered like an id of no window (no reply). Existing ids behave as before. Verified: cargo check --workspace --all-targets in komorebi-for-kde: 0 errors; cargo test -p komorebi --test rule_commands: 6 passed, 0 failed (it sends DebugWindow). --- komorebi-for-kde/komorebi/src/core/mod.rs | 2 +- komorebi-for-kde/komorebi/src/process_command.rs | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/komorebi-for-kde/komorebi/src/core/mod.rs b/komorebi-for-kde/komorebi/src/core/mod.rs index 8d7bc2f2..fa8bd243 100644 --- a/komorebi-for-kde/komorebi/src/core/mod.rs +++ b/komorebi-for-kde/komorebi/src/core/mod.rs @@ -613,7 +613,7 @@ pub enum SocketMessage { SocketSchema, StaticConfigSchema, GenerateStaticConfig, - DebugWindow(u32), + DebugWindow(i64), ReloadHotkeys, HotkeysState, } diff --git a/komorebi-for-kde/komorebi/src/process_command.rs b/komorebi-for-kde/komorebi/src/process_command.rs index 993e57bc..f694bcc3 100644 --- a/komorebi-for-kde/komorebi/src/process_command.rs +++ b/komorebi-for-kde/komorebi/src/process_command.rs @@ -1974,8 +1974,11 @@ impl WindowManager { self.update_focused_workspace(false, false)?; } SocketMessage::DebugWindow(window_id) => { - let window = Window::from(window_id); - if window.is_valid() { + // an id that is not a u32 is not a window + let window = u32::try_from(window_id).map(Window::from); + if let Ok(window) = window + && window.is_valid() + { let mut rule_debug = RuleDebug::default(); let _ = window.should_manage(None, &mut rule_debug); let schema = serde_json::to_string_pretty(&rule_debug)?;