From 55339cfcb38b06a1b35e4d6927826fc9ae367434 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Fri, 6 Nov 2026 14:05:06 -0800 Subject: [PATCH] test(e2e): the macOS class checks pass, so they are no longer marked The test window now has a class (its accessibility subrole), and the state has it, so manage_rules, state_fidelity and rules_class pass against a real guest: the three known failures of the class difference and the skip of rules_class are removed. A run with a mark on a check that passes reports it as a failure, so they could not stay. placement stays skipped, for the initial_window_placement_rules the daemon does not have. --- e2e/platforms/tart_macos/run.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/e2e/platforms/tart_macos/run.py b/e2e/platforms/tart_macos/run.py index 94ca7fa7..89961ad4 100644 --- a/e2e/platforms/tart_macos/run.py +++ b/e2e/platforms/tart_macos/run.py @@ -54,7 +54,6 @@ UNSUPPORTED = { "focus_follows_mouse": "a macOS guest has no pointer, and the daemon has no focus follows mouse", "locking": "a macOS guest has no lock screen to test", "wallpaper": "the wallpaper of a macOS guest is not read yet", - "rules_class": "a macOS window has no class", "placement": "the macOS daemon has no initial_window_placement_rules", "resize": "a macOS guest has no pointer to drag an edge with", "maximizing": "the macOS komorebic has no toggle-maximize", @@ -77,10 +76,6 @@ DIFFERENCES = { "the daemon tiles 10 px below the top of the work area the system reports and 12 px above " "its bottom, so a vertical mirror is a few pixels off" ), - "class": ( - "a macOS window has no class: the daemon matches the role of the window, which every " - "window of the test program shares" - ), } # the checks of a scenario that are about one of them, by a part of their description; the others @@ -100,13 +95,6 @@ KNOWN_CHECKS = { "BSP, 3 windows, layout_flip Vertical: ... each where the mirror of its place is": "margins", "BSP, 3 windows, layout_flip HorizontalAndVertical: ... each where the mirror of its place is": "margins", }, - "manage_rules": { - "an ignore rule by class matches is not managed": "class", - "keeps its place (class)": "class", - }, - "state_fidelity": { - "the state has the class a window was given": "class", - }, } KNOWN_CHECKS = { scenario: {key: DIFFERENCES[name] for key, name in marks.items()}