From 48861ece10c253e5d7280a99af12cdb7b232cfc1 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 15:17:43 -0700 Subject: [PATCH] docs: correct the title-bar claim and name the renamed hook (F2, F3) docs/dev/core-model.md section 19: remove_floating_window's hook is before_floating_removed (behaviour unchanged), and the Windows title-bar tables are taken once per pass through begin_pass; the sentence of section 16 that called the per-container read an improvement is corrected. Verified: not applicable (documentation). --- docs/dev/core-model.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/docs/dev/core-model.md b/docs/dev/core-model.md index 4e150a99..61cc519e 100644 --- a/docs/dev/core-model.md +++ b/docs/dev/core-model.md @@ -1122,7 +1122,7 @@ compiles unchanged; the defaults of the ones a daemon must provide return an err implementation departs from section 12: `adjust_layout` and `place_container` take the container and the tile, not its index; the guard of `begin_update` is a boxed `dyn Any` (no associated type, so macOS needs nothing); the KDE closure around the placement is gone (it had nothing between it and -its `?`); the Windows title-bar tables are read once per container instead of once per pass. +its `?`); the Windows title-bar tables were first read once per container instead of once per pass, which was a regression, not an improvement: section 19 (the `begin_pass` hook) takes them once per pass again. **What macOS keeps (kfm's `update`, not touched):** its `update` is another shape, not the same text with other hooks. It wraps the placement in SkyLight's `SLSDisableUpdate`/`SLSReenableUpdate` (a @@ -1302,3 +1302,16 @@ Recommended next step: shared text first between KDE and macOS (kfm and kfde), w functions and most router arms are already identical, then Windows converges onto it function by function against the blocker list above; creating `WindowManager

` before blockers 1 to 3 are decided would move less than half of the file. + +## 19. Corrections after the review of `komorebi-core` (findings F2 and F3) + +- **F2, the floating-window hook.** `Workspace::remove_floating_window` calls the hook before it takes the + window out of the ring (the KDE and macOS originals move the focus first, and the focus index moves + back by one whatever the length), so the hook is `before_floating_removed`, not `after_floating_removed` + as sections 8 to 11 call it. Behaviour is unchanged; a test pins the order. +- **F3, the title-bar snapshot.** The original Windows `update` read `REMOVE_TITLEBARS`, `NO_TITLEBAR` and + `REGEX_IDENTIFIERS` once per placement pass; the first Windows `place_container` read them per container, + so a configuration reload in the middle of a pass could give two containers two tables (section 16 + wrongly called this an improvement). `WorkspacePlatform::begin_pass` is called once per pass after the + layout is computed and its answer reaches the hooks as `Placement::pass`; Windows takes the snapshot + there and `place_container` reads it, as the original did.