chore(stackbar): tighten deadlock fix comment

This commit is contained in:
Dylan Anderson
2026-08-02 20:24:18 -07:00
committed by Jeezy
parent 5a534eb2ac
commit 3f3fac8b65
+2 -4
View File
@@ -174,10 +174,8 @@ impl Stackbar {
let focused_text_colour = STACKBAR_FOCUSED_TEXT_COLOUR.load_consume(); let focused_text_colour = STACKBAR_FOCUSED_TEXT_COLOUR.load_consume();
let unfocused_text_colour = STACKBAR_UNFOCUSED_TEXT_COLOUR.load_consume(); let unfocused_text_colour = STACKBAR_UNFOCUSED_TEXT_COLOUR.load_consume();
// Scope the lock so it is released before the synchronous position_window // The wndproc takes this lock on WM_LBUTTONDOWN, so release it before the
// call below; the window's wndproc takes the same lock on WM_LBUTTONDOWN, // synchronous position_window call below or the two threads can deadlock
// and holding it across a cross-thread SetWindowPos deadlocks the two
// threads against each other (mutex <-> message queue cycle)
{ {
let mut stackbars_containers = STACKBARS_CONTAINERS.lock(); let mut stackbars_containers = STACKBARS_CONTAINERS.lock();
stackbars_containers.insert(self.hwnd, container.clone()); stackbars_containers.insert(self.hwnd, container.clone());