From 12ef908aa97d63cebb58a0c2aced65a734834ad2 Mon Sep 17 00:00:00 2001
From: LGUG2Z <LGUG2Z@fastmail.com>
Date: Sat, 31 Oct 2026 11:16:32 -0700
Subject: [PATCH] test(windows): pin the JSON of Monitor and MonitorInformation

Three unit tests in monitor.rs: a Monitor read from the monitor object of a
real komorebic state capture (e2e/lib/tests/fixtures/kfw-tiled.json, its
workspaces emptied) serializes back to the same JSON value; id and
serial_number_id are plain JSON values for ids including isize::MAX, -1 and
isize::MIN; MonitorInformation has the six documented fields. They fix the
representation before the type of Monitor.id changes.

The komorebi crate is Windows-only, so these compile (clippy --all-targets,
PASS) but cannot run on this host: they have NOT been run. Not a behaviour
change.
---
 komorebi/src/monitor.rs | 61 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/komorebi/src/monitor.rs b/komorebi/src/monitor.rs
index ee4d2c53..6a769379 100644
--- a/komorebi/src/monitor.rs
+++ b/komorebi/src/monitor.rs
@@ -821,4 +821,65 @@ mod tests {
         m.ensure_workspace_count(3);
         assert_eq!(m.workspaces().len(), 5, "Monitor should have 5 workspaces");
     }
+
+    /// The monitor object of a real `komorebic state` capture (e2e/lib/tests/fixtures/kfw-tiled.json,
+    /// workspaces emptied): the JSON a Monitor reads and writes. Pins the representation of `id` (a
+    /// plain number) and `serial_number_id` (null or a string) so that changing their Rust types
+    /// cannot change the state JSON.
+    const MONITOR_JSON: &str = r#"{
+        "id": 65537,
+        "name": "DISPLAY1",
+        "device": "Default_Monitor",
+        "device_id": "Default_Monitor-4&183790ca&0&UID0",
+        "serial_number_id": null,
+        "size": { "left": 0, "top": 0, "right": 1280, "bottom": 800 },
+        "work_area_size": { "left": 0, "top": 0, "right": 1280, "bottom": 752 },
+        "work_area_offset": null,
+        "window_based_work_area_offset": null,
+        "window_based_work_area_offset_limit": 1,
+        "workspaces": { "elements": [], "focused": 0 },
+        "workspace_names": {},
+        "container_padding": null,
+        "workspace_padding": null,
+        "wallpaper": null,
+        "floating_layer_behaviour": null
+    }"#;
+
+    #[test]
+    fn a_monitor_serializes_to_the_json_of_the_state_capture() {
+        let expected: serde_json::Value = serde_json::from_str(MONITOR_JSON).unwrap();
+        let monitor: Monitor = serde_json::from_value(expected.clone()).unwrap();
+
+        assert_eq!(serde_json::to_value(&monitor).unwrap(), expected);
+    }
+
+    #[test]
+    fn a_monitor_id_and_serial_are_plain_json_values() {
+        for id in [0, 1, 65537, isize::MAX, -1, isize::MIN] {
+            let mut value: serde_json::Value = serde_json::from_str(MONITOR_JSON).unwrap();
+            value["id"] = serde_json::json!(id);
+            value["serial_number_id"] = serde_json::json!("ABC123");
+
+            let monitor: Monitor = serde_json::from_value(value.clone()).unwrap();
+            assert_eq!(serde_json::to_value(&monitor).unwrap(), value, "id {id}");
+        }
+    }
+
+    #[test]
+    fn monitor_information_has_the_documented_fields() {
+        let monitor: Monitor = serde_json::from_str(MONITOR_JSON).unwrap();
+        let value = serde_json::to_value(MonitorInformation::from(&monitor)).unwrap();
+
+        assert_eq!(
+            value,
+            serde_json::json!({
+                "id": 65537,
+                "name": "DISPLAY1",
+                "device": "Default_Monitor",
+                "device_id": "Default_Monitor-4&183790ca&0&UID0",
+                "serial_number_id": null,
+                "size": { "left": 0, "top": 0, "right": 1280, "bottom": 800 }
+            })
+        );
+    }
 }