From 1e10f45bb97e154860ffe1c29113939dbfa3e35c Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 10:12:30 -0700 Subject: [PATCH 01/11] refactor(config): StaticConfig::read takes &Path, not &PathBuf clippy::ptr_arg: the function only opens the file, so any path will do, and every caller that passes a &PathBuf still compiles through deref. Needed so the macOS StaticConfigExt methods can take &Path (next revision). Verified: fast-check native, Windows clippy -D warnings, KDE check and lib tests, macOS fake-CC type-check PASS. Verified on the Mini: not yet. --- crates/komorebi-config/src/static_config.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/komorebi-config/src/static_config.rs b/crates/komorebi-config/src/static_config.rs index b08e339f..109e040f 100644 --- a/crates/komorebi-config/src/static_config.rs +++ b/crates/komorebi-config/src/static_config.rs @@ -617,7 +617,7 @@ impl StaticConfig { /// # Errors /// /// The file cannot be read, or it is not a configuration. - pub fn read(path: &PathBuf) -> color_eyre::Result { + pub fn read(path: &std::path::Path) -> color_eyre::Result { let content = std::fs::read_to_string(path)?; serde_json::from_str(&content).map_err(Into::into) } From 1c64168759df382c7229b05188fb264e7a0c9430 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 10:12:30 -0700 Subject: [PATCH 02/11] fix(mac): StaticConfigExt takes &Path instead of &PathBuf (clippy::ptr_arg) Fixes the 3 new lints at static_config.rs:719, :726 and :729 (the trait declarations of preload, postload and reload; the impls follow). They were introduced by kvtvnouo, 'refactor(mac): use StaticConfig and its family of komorebi-config', which turned the inherent methods into the extension trait; the original tip 9a58e511 did not have them. read gets a &Path through the previous revision, and the one clone of the path (the ReloadStaticConfiguration message) is path.to_path_buf(). No behaviour change. Verified: macOS fake-CC type-check (tools/fast-check) PASS, and fake-CC cargo clippy -p komorebi --all-targets -D warnings no longer reports the three. Verified on the Mini: not yet (cargo clippy --all-targets -D warnings). --- komorebi-for-mac/komorebi/src/static_config.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/komorebi-for-mac/komorebi/src/static_config.rs b/komorebi-for-mac/komorebi/src/static_config.rs index 3cd71ee4..ccc5b865 100644 --- a/komorebi-for-mac/komorebi/src/static_config.rs +++ b/komorebi-for-mac/komorebi/src/static_config.rs @@ -64,6 +64,7 @@ use std::io::ErrorKind; use std::io::Write; use std::os::unix::net::UnixListener; use std::os::unix::net::UnixStream; +use std::path::Path; use std::path::PathBuf; use std::sync::Arc; use std::sync::atomic::Ordering; @@ -716,23 +717,23 @@ impl ApplyGlobals for StaticConfig { pub trait StaticConfigExt: Sized { /// Makes the window manager from the file at `path`, and starts watching the file fn preload( - path: &PathBuf, + path: &Path, incoming: Receiver, unix_listener: Option, run_loop: &CFRetained, ) -> eyre::Result; /// Gives the monitors of the window manager what the file says about them - fn postload(path: &PathBuf, wm: &Arc>) -> eyre::Result<()>; + fn postload(path: &Path, wm: &Arc>) -> eyre::Result<()>; /// Replaces the configuration of the window manager with the file at `path` - fn reload(path: &PathBuf, wm: &mut WindowManager) -> eyre::Result<()>; + fn reload(path: &Path, wm: &mut WindowManager) -> eyre::Result<()>; } impl StaticConfigExt for StaticConfig { #[allow(clippy::too_many_lines)] fn preload( - path: &PathBuf, + path: &Path, incoming: Receiver, unix_listener: Option, run_loop: &CFRetained, @@ -811,7 +812,7 @@ impl StaticConfigExt for StaticConfig { known_window_ids: HashMap::new(), }; - let bytes = SocketMessage::ReloadStaticConfiguration(path.clone()).as_bytes()?; + let bytes = SocketMessage::ReloadStaticConfiguration(path.to_path_buf()).as_bytes()?; wm.hotwatch.watch(path, move |event| match event.kind { // Editing in Notepad sends a NoticeWrite while editing in (Neo)Vim sends @@ -830,7 +831,7 @@ impl StaticConfigExt for StaticConfig { Ok(wm) } - fn postload(path: &PathBuf, wm: &Arc>) -> eyre::Result<()> { + fn postload(path: &Path, wm: &Arc>) -> eyre::Result<()> { let mut value = Self::read(path)?; let mut wm = wm.lock(); @@ -992,7 +993,7 @@ impl StaticConfigExt for StaticConfig { Ok(()) } - fn reload(path: &PathBuf, wm: &mut WindowManager) -> eyre::Result<()> { + fn reload(path: &Path, wm: &mut WindowManager) -> eyre::Result<()> { let mut value = Self::read(path)?; value.apply_globals()?; From 552ab43701d8ccddc86dbc848491863e7bbfa855 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 10:12:30 -0700 Subject: [PATCH 03/11] style(mac): take the workspaces with mem::take instead of drain(..).collect() (clippy::drain_collect) monitor.rs remove_workspaces moved every workspace into a new VecDeque through drain; mem::take moves the whole deque and leaves an empty one, which is the same result without the second allocation. No behaviour change. Pre-existing on the original macOS tip 9a58e511 (reported by cargo clippy --all-targets -D warnings on the Mini, stable 1.93). Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin -p komorebi --all-targets -D warnings no longer reports this lint (see the last hygiene revision for the whole run). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/src/monitor.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/komorebi-for-mac/komorebi/src/monitor.rs b/komorebi-for-mac/komorebi/src/monitor.rs index 5703086d..47713613 100644 --- a/komorebi-for-mac/komorebi/src/monitor.rs +++ b/komorebi-for-mac/komorebi/src/monitor.rs @@ -577,7 +577,7 @@ impl Monitor { } pub fn remove_workspaces(&mut self) -> VecDeque { - self.workspaces_mut().drain(..).collect() + std::mem::take(self.workspaces_mut()) } pub fn ensure_workspace_count(&mut self, ensure_count: usize) { From 756a03cc77168f0c1f59fe38e1770e3dfe1a1e80 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:37:01 -0700 Subject: [PATCH 04/11] style(mac): use Option::filter for the non-empty window name (clippy::manual_filter) window.rs WindowInfo::from(&CFDictionary) spelled filter by hand with and_then; an empty name is still None. No behaviour change. Pre-existing on the original macOS tip 9a58e511 (reported by cargo clippy --all-targets -D warnings on the Mini, stable 1.93). Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin -p komorebi --all-targets -D warnings no longer reports this lint (see the last hygiene revision for the whole run). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/src/window.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/komorebi-for-mac/komorebi/src/window.rs b/komorebi-for-mac/komorebi/src/window.rs index 247b887e..595e6702 100644 --- a/komorebi-for-mac/komorebi/src/window.rs +++ b/komorebi-for-mac/komorebi/src/window.rs @@ -1587,7 +1587,7 @@ impl From<&CFDictionary> for WindowInfo { Self { name: cf_dictionary_value::(value, kCGWindowName) .map(|s| s.as_ref().to_string()) - .and_then(|s| if s.is_empty() { None } else { Some(s) }), + .filter(|s| !s.is_empty()), owner_pid: cf_dictionary_value::(value, kCGWindowOwnerPID) .and_then(|s| s.as_ref().as_i32()) .expect("window must have an owner process id"), From d9837200c391ec0b75159b62a93888f3aa2a5253 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:37:01 -0700 Subject: [PATCH 05/11] style(mac): fill resize_dimensions with None in one call (clippy::manual_slice_fill) window_manager.rs reset every entry of workspace.resize_dimensions in a for loop; fill(None) does the same. No behaviour change. Pre-existing on the original macOS tip 9a58e511 (reported by cargo clippy --all-targets -D warnings on the Mini, stable 1.93). Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin -p komorebi --all-targets -D warnings no longer reports this lint (the last hygiene revision records the whole run). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/src/window_manager.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/komorebi-for-mac/komorebi/src/window_manager.rs b/komorebi-for-mac/komorebi/src/window_manager.rs index c7435da3..48d66dac 100644 --- a/komorebi-for-mac/komorebi/src/window_manager.rs +++ b/komorebi-for-mac/komorebi/src/window_manager.rs @@ -2265,9 +2265,7 @@ impl WindowManager { // Reset any resize adjustments if we want to force a retile if !preserve_resize_dimensions { - for resize in &mut workspace.resize_dimensions { - *resize = None; - } + workspace.resize_dimensions.fill(None); // and the widths and heights of the Scrolling layout, which are resize // adjustments too From f9f47f3fb4b6655a82214103dd46426ce13b5a79 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:37:18 -0700 Subject: [PATCH 06/11] style(mac): sort the layout rules with sort_by_key (clippy::unnecessary_sort_by) window_manager.rs sorted (usize, Layout) pairs by their first field with a comparator closure; sort_by_key on the same field is the same stable sort. No behaviour change. Pre-existing on the original macOS tip 9a58e511 (reported by cargo clippy --all-targets -D warnings on the Mini, stable 1.93). Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin -p komorebi --all-targets -D warnings no longer reports this lint (the last hygiene revision records the whole run). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/src/window_manager.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/komorebi-for-mac/komorebi/src/window_manager.rs b/komorebi-for-mac/komorebi/src/window_manager.rs index 48d66dac..e9dc083b 100644 --- a/komorebi-for-mac/komorebi/src/window_manager.rs +++ b/komorebi-for-mac/komorebi/src/window_manager.rs @@ -3515,7 +3515,7 @@ impl WindowManager { let rules: &mut Vec<(usize, Layout)> = &mut workspace.layout_rules; rules.retain(|pair| pair.0 != at_container_count); rules.push((at_container_count, Layout::Default(layout))); - rules.sort_by(|a, b| a.0.cmp(&b.0)); + rules.sort_by_key(|a| a.0); // If this is the focused workspace on a non-focused screen, let's update it if focused_monitor_idx != monitor_idx && focused_workspace_idx == workspace_idx { From 5055e8a639492d1d983377818dbe4a910631ea50 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:37:19 -0700 Subject: [PATCH 07/11] style(mac): allow clippy::collapsible_match at three nested ifs, with a reason monitor.rs (two ifs that choose where a moved container goes, inside a match on the layout) and static_config.rs handle_asc_file (a 40-line block under the extension check). The lint wants the if folded into the outer match arm as a guard; doing that restructures the arms (the else branches become extra arms) without changing what they do, which is more edit than a lint fix should be and cannot be run here, so each site gets an allow with a comment instead. No behaviour change. Pre-existing on the original macOS tip 9a58e511. Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin -p komorebi --all-targets -D warnings: the daemon lib and its tests are clean with the six hygiene and ptr_arg revisions applied (the whole-workspace run still reports newer-clippy lints that the Mini's 1.93 does not have: the bar's f32 literal fallback and examples/capture_spike.rs chunks_exact). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/src/monitor.rs | 2 ++ komorebi-for-mac/komorebi/src/static_config.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/komorebi-for-mac/komorebi/src/monitor.rs b/komorebi-for-mac/komorebi/src/monitor.rs index 47713613..967abe51 100644 --- a/komorebi-for-mac/komorebi/src/monitor.rs +++ b/komorebi-for-mac/komorebi/src/monitor.rs @@ -467,6 +467,7 @@ impl Monitor { workspace.add_container_to_front(container); } DefaultLayout::UltrawideVerticalStack => { + #[allow(clippy::collapsible_match)] // the outer match has one arm per layout; collapsing would restructure it if workspace.containers().len() == 1 { workspace.insert_container_at_idx(0, container); } else { @@ -489,6 +490,7 @@ impl Monitor { match layout { DefaultLayout::RightMainVerticalStack | DefaultLayout::UltrawideVerticalStack => { + #[allow(clippy::collapsible_match)] // the outer match has one arm per layout; collapsing would restructure it if workspace.containers().len() == 1 { workspace.add_container_to_back(container); } else { diff --git a/komorebi-for-mac/komorebi/src/static_config.rs b/komorebi-for-mac/komorebi/src/static_config.rs index ccc5b865..6fbb0341 100644 --- a/komorebi-for-mac/komorebi/src/static_config.rs +++ b/komorebi-for-mac/komorebi/src/static_config.rs @@ -1256,6 +1256,7 @@ fn handle_asc_file( match path.extension() { None => {} Some(ext) => { + #[allow(clippy::collapsible_match)] // collapsing the nested if into a guard would restructure a 40-line block if ext.to_string_lossy().to_string().as_str() == "json" { tracing::info!("loading applications.json from: {}", path.display()); let mut asc = ApplicationSpecificConfiguration::load(path)?; From a35573d8eb8ca34b6690168f32fdaefc51194b49 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:38:08 -0700 Subject: [PATCH 08/11] fix(kde): StaticConfigExt takes &Path instead of &PathBuf (clippy::ptr_arg) The KDE twin of the macOS fix: the trait declarations of preload, postload and reload (static_config.rs:726, :732, :735; the impls follow) took &PathBuf, introduced by the same step 3 conversion to the extension trait. read takes &Path since the config-crate revision; the one clone of the path is path.to_path_buf(). No behaviour change. Verified: native cargo clippy --locked -p komorebi --all-targets -D warnings in komorebi-for-kde: clean (the 3 ptr_arg errors that predated the backend work are gone); cargo test --locked -p komorebi --lib: 294 passed, 0 failed. --- komorebi-for-kde/komorebi/src/static_config.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/komorebi-for-kde/komorebi/src/static_config.rs b/komorebi-for-kde/komorebi/src/static_config.rs index 92658913..e73caa32 100644 --- a/komorebi-for-kde/komorebi/src/static_config.rs +++ b/komorebi-for-kde/komorebi/src/static_config.rs @@ -86,6 +86,7 @@ use std::io::ErrorKind; use std::io::Write; use std::os::unix::net::UnixListener; use std::os::unix::net::UnixStream; +use std::path::Path; use std::path::PathBuf; use std::sync::Arc; use std::sync::atomic::Ordering; @@ -723,16 +724,16 @@ impl ApplyGlobals for StaticConfig { pub trait StaticConfigExt: Sized { /// Makes the window manager from the file at `path`, and starts watching the file fn preload( - path: &PathBuf, + path: &Path, incoming: Receiver, unix_listener: Option, ) -> eyre::Result; /// Gives the monitors of the window manager what the file says about them - fn postload(path: &PathBuf, wm: &Arc>) -> eyre::Result<()>; + fn postload(path: &Path, wm: &Arc>) -> eyre::Result<()>; /// Replaces the configuration of the window manager with the file at `path` - fn reload(path: &PathBuf, wm: &mut WindowManager) -> eyre::Result<()>; + fn reload(path: &Path, wm: &mut WindowManager) -> eyre::Result<()>; } impl StaticConfigExt for StaticConfig { @@ -755,7 +756,7 @@ impl StaticConfigExt for StaticConfig { /// - The file cannot be watched. #[allow(clippy::too_many_lines)] fn preload( - path: &PathBuf, + path: &Path, incoming: Receiver, unix_listener: Option, ) -> eyre::Result { @@ -830,7 +831,7 @@ impl StaticConfigExt for StaticConfig { known_window_ids: HashMap::new(), }; - let bytes = SocketMessage::ReloadStaticConfiguration(path.clone()).as_bytes()?; + let bytes = SocketMessage::ReloadStaticConfiguration(path.to_path_buf()).as_bytes()?; wm.hotwatch.watch(path, move |event| match event.kind { // an editor either writes the file in place or replaces it with a new one, which is a @@ -860,7 +861,7 @@ impl StaticConfigExt for StaticConfig { /// # Errors /// /// The file cannot be read or is not a configuration ([`StaticConfig::read`]). - fn postload(path: &PathBuf, wm: &Arc>) -> eyre::Result<()> { + fn postload(path: &Path, wm: &Arc>) -> eyre::Result<()> { let mut value = Self::read(path)?; let mut wm = wm.lock(); @@ -1036,7 +1037,7 @@ impl StaticConfigExt for StaticConfig { /// - The file cannot be read or is not a configuration ([`StaticConfig::read`]); nothing has /// changed then. /// - A rule has a regular expression that is not valid; the settings before it have changed. - fn reload(path: &PathBuf, wm: &mut WindowManager) -> eyre::Result<()> { + fn reload(path: &Path, wm: &mut WindowManager) -> eyre::Result<()> { let mut value = Self::read(path)?; value.apply_globals()?; From b9125ddb6561b00ff259de5b52058a501007f61d Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:43:21 -0700 Subject: [PATCH 09/11] style(mac): sample the capture spike's pixels with chunks(4) and a length filter (clippy) examples/capture_spike.rs iterated bytes.chunks_exact(4), which clippy flags as chunks_exact_with_const_size on 1.93 and as chunks_exact_to_as_chunks on 1.99 (the allow name differs between the two, so an allow cannot serve both). chunks(4).filter(len == 4) visits the same full pixels in the same order and still drops a trailing partial one; the spike is an example binary, not the daemon. No behaviour change. Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin --workspace --all-targets -D warnings: clean (whole workspace). Verified on the Mini: not yet. --- komorebi-for-mac/komorebi/examples/capture_spike.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/komorebi-for-mac/komorebi/examples/capture_spike.rs b/komorebi-for-mac/komorebi/examples/capture_spike.rs index c2d93b16..747d8170 100644 --- a/komorebi-for-mac/komorebi/examples/capture_spike.rs +++ b/komorebi-for-mac/komorebi/examples/capture_spike.rs @@ -46,7 +46,8 @@ fn sample(data: &CFData) -> (f64, f64) { let bytes = data.to_vec(); let (mut total, mut visible, mut lit) = (0usize, 0usize, 0usize); - for pixel in bytes.chunks_exact(4).step_by(37) { + // a trailing partial pixel (a buffer that is not a multiple of 4) is dropped, as chunks_exact did + for pixel in bytes.chunks(4).filter(|pixel| pixel.len() == 4).step_by(37) { total += 1; if pixel[3] > 0 { visible += 1; From afd0f82f91f178ac2df2989a680f04ad24298eef Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:43:21 -0700 Subject: [PATCH 10/11] style(mac-bar): spell the stroke widths 1.0_f32 (float_literal_f32_fallback) Six literals in the macOS bar (applications.rs, komorebi.rs x3, komorebi_layout.rs, time.rs) passed 1.0 to egui's Stroke::new, which rustc 1.99 reports as an f32 fallback (a future hard error). The Windows bar and komorebi-bar-core already say 1.0_f32 for the same calls, so this makes the macOS bar text match them; the value is the same f32. No behaviour change. Verified: fake-CC cargo clippy --locked --target aarch64-apple-darwin --workspace --all-targets -D warnings: clean (whole workspace). The Windows bar and komorebi-bar-core are untouched. Verified on the Mini: not yet. --- komorebi-for-mac/komorebi-bar/src/widgets/applications.rs | 2 +- komorebi-for-mac/komorebi-bar/src/widgets/komorebi.rs | 6 +++--- .../komorebi-bar/src/widgets/komorebi_layout.rs | 2 +- komorebi-for-mac/komorebi-bar/src/widgets/time.rs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/komorebi-for-mac/komorebi-bar/src/widgets/applications.rs b/komorebi-for-mac/komorebi-bar/src/widgets/applications.rs index e2d75250..edbe115d 100644 --- a/komorebi-for-mac/komorebi-bar/src/widgets/applications.rs +++ b/komorebi-for-mac/komorebi-bar/src/widgets/applications.rs @@ -310,7 +310,7 @@ impl Icon { #[inline] pub fn draw_fallback(ui: &mut Ui, icon_size: Vec2) { let (response, painter) = ui.allocate_painter(icon_size, Sense::hover()); - let stroke = Stroke::new(1.0, ui.style().visuals.text_color()); + let stroke = Stroke::new(1.0_f32, ui.style().visuals.text_color()); let mut rect = response.rect; let rounding = CornerRadius::same((rect.width() * 0.1) as u8); rect = rect.shrink(stroke.width); diff --git a/komorebi-for-mac/komorebi-bar/src/widgets/komorebi.rs b/komorebi-for-mac/komorebi-bar/src/widgets/komorebi.rs index 0b9cbaf5..cc1d1621 100644 --- a/komorebi-for-mac/komorebi-bar/src/widgets/komorebi.rs +++ b/komorebi-for-mac/komorebi-bar/src/widgets/komorebi.rs @@ -474,7 +474,7 @@ impl WorkspacesBar { .show(ui, |ui| { let (response, painter) = ui.allocate_painter(self.icon_size, Sense::hover()); let stroke: Stroke = Stroke::new( - 1.0, + 1.0_f32, if ws.is_selected { ctx.style().visuals.selection.stroke.color } else { @@ -643,7 +643,7 @@ impl WorkspaceLayerBar { if matches!(layer, WorkspaceLayer::Tiling) { let (response, painter) = ui.allocate_painter(size, Sense::hover()); let color = ctx.style().visuals.selection.stroke.color; - let stroke = Stroke::new(1.0, color); + let stroke = Stroke::new(1.0_f32, color); let mut rect = response.rect; let corner = CornerRadius::same((rect.width() * 0.1) as u8); rect = rect.shrink(stroke.width); @@ -666,7 +666,7 @@ impl WorkspaceLayerBar { } else { let (response, painter) = ui.allocate_painter(size, Sense::hover()); let color = ctx.style().visuals.selection.stroke.color; - let stroke = Stroke::new(1.0, color); + let stroke = Stroke::new(1.0_f32, color); let mut rect = response.rect; let corner = CornerRadius::same((rect.width() * 0.1) as u8); rect = rect.shrink(stroke.width); diff --git a/komorebi-for-mac/komorebi-bar/src/widgets/komorebi_layout.rs b/komorebi-for-mac/komorebi-bar/src/widgets/komorebi_layout.rs index c6b1c6a8..fffd5e38 100644 --- a/komorebi-for-mac/komorebi-bar/src/widgets/komorebi_layout.rs +++ b/komorebi-for-mac/komorebi-bar/src/widgets/komorebi_layout.rs @@ -146,7 +146,7 @@ impl KomorebiLayout { } else { ui.style().visuals.text_color() }; - let stroke = Stroke::new(1.0, color); + let stroke = Stroke::new(1.0_f32, color); let mut rect = response.rect; let rounding = CornerRadius::same((rect.width() * 0.1) as u8); rect = rect.shrink(stroke.width); diff --git a/komorebi-for-mac/komorebi-bar/src/widgets/time.rs b/komorebi-for-mac/komorebi-bar/src/widgets/time.rs index 384741a9..63b40226 100644 --- a/komorebi-for-mac/komorebi-bar/src/widgets/time.rs +++ b/komorebi-for-mac/komorebi-bar/src/widgets/time.rs @@ -317,7 +317,7 @@ impl Time { let (response, painter) = ui.allocate_painter(Vec2::new(width, full_height + offset * 2.0), Sense::hover()); let color = ctx.style().visuals.text_color(); - let stroke = Stroke::new(1.0, color); + let stroke = Stroke::new(1.0_f32, color); let round_all = CornerRadius::same((response.rect.width() * 0.1) as u8); let round_top = CornerRadius { From 29bdd0b2c7ec8ed75650b8103d4368f74e7894ed Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 31 Oct 2026 12:43:59 -0700 Subject: [PATCH 11/11] docs(macos): record that the Mini runs so far are compile and unit tests only Adds a status section to the hand-check list: cargo test --workspace passed on the Mini (daemon 366 passed, 1 ignored) and clippy is clean, but nothing was run as a daemon, so every walk-through item stays open. Verified: documentation only. --- docs/dev/macos-handcheck.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/dev/macos-handcheck.md b/docs/dev/macos-handcheck.md index 026ed895..d6f939cb 100644 --- a/docs/dev/macos-handcheck.md +++ b/docs/dev/macos-handcheck.md @@ -4,6 +4,10 @@ Status: written by the `kfm` agent for the user, 2026-10-31. Nothing here has be How to use it: build the unified (or, until they exist, the per-tree) macOS `komorebi`, `komorebic` and `komorebi-bar`, run `cargo test --workspace` on the Mac first (the 399+ unit tests have never run against these changes), then walk the sections in order. For before/after capture use `komorebi-recorder` against a build of the baseline `wip-main` ancestor `ff3711dc` and the tip. A section is done when the "look for" column is true. +## Status of the Mini runs (2026-10-31) + +The real-Mac runs so far (Mac Mini, rustc and clippy 1.93, tip a35573d8) are **compile and unit tests only**: `cargo test --workspace` in komorebi-for-mac passed (daemon 366 passed, 1 ignored; 368 total, 0 failed) and clippy `-D warnings` was clean apart from the two items fixed afterwards. Nothing was run as a daemon: no focus, tiling, borders, animations or bar rendering has been observed on the Mini. Every walk-through item below is still open. + ## A. Revisions that change what the daemon does (BEHAVIOUR) | Revision | What changed | Look for on a Mac |