starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Question] Is this supposed to be like this? #978

New Issue
Closed
opened 2025-12-29 02:26:59 +01:00 by adam · 2 comments
adam commented 2025-12-29 02:26:59 +01:00
Owner
Copy Link

Originally created by @bitbronze on GitHub (Mar 18, 2025).

Use case

This is affecting some behavior in ListPreauthKeys.

Description

In file users.go

// Username is the main way to get the username of a user,
// it will return the email if it exists, the name if it exists,
// the OIDCIdentifier if it exists, and the ID if nothing else exists.
// Email and OIDCIdentifier will be set when the user has headscale
// enabled with OIDC, which means that there is a domain involved which
// should be used throughout headscale, in information returned to the
// user and the Policy engine.
func (u *User) Username() string {
	return cmp.Or(
		u.Email,
		u.Name,
		u.ProviderIdentifier.String,
		u.StringID(),
	)
}

The email is returned with priority over the actual username. Should we swap u.Email and u.Name?

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

No response

Originally created by @bitbronze on GitHub (Mar 18, 2025). ### Use case This is affecting some behavior in ListPreauthKeys. ### Description In file [users.go](https://github.com/juanfont/headscale/blob/00d5d647ed560b716c5277cb81228a9442b25cf3/hscontrol/types/users.go#L86) ``` // Username is the main way to get the username of a user, // it will return the email if it exists, the name if it exists, // the OIDCIdentifier if it exists, and the ID if nothing else exists. // Email and OIDCIdentifier will be set when the user has headscale // enabled with OIDC, which means that there is a domain involved which // should be used throughout headscale, in information returned to the // user and the Policy engine. func (u *User) Username() string { return cmp.Or( u.Email, u.Name, u.ProviderIdentifier.String, u.StringID(), ) } ``` The email is returned with priority over the actual username. Should we swap u.Email and u.Name? ### Contribution - [ ] I can write the design doc for this feature - [ ] I can contribute this feature ### How can it be implemented? _No response_
adam added the enhancement label 2025-12-29 02:26:59 +01:00
adam closed this issue 2025-12-29 02:26:59 +01:00
adam commented 2025-12-29 02:26:59 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Mar 19, 2025):

This is intended behaviour.

Is the affected behaviour that the cli don't use id?

@kradalby commented on GitHub (Mar 19, 2025): This is intended behaviour. Is the affected behaviour that the cli don't use id?
adam commented 2025-12-29 02:27:00 +01:00
Author
Owner
Copy Link

@bitbronze commented on GitHub (Mar 19, 2025):

API returns emails instead of username in the "user" field. And for other API commands Headscale expects username not email. So for example expiring a preauthkey.

@bitbronze commented on GitHub (Mar 19, 2025): API returns emails instead of username in the "user" field. And for other API commands Headscale expects username not email. So for example expiring a preauthkey.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?