starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Separate user and server errors in http handlers #930

New Issue
Closed
opened 2025-12-29 02:26:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:26:17 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Jan 29, 2025).

At the moment, all errors that occur in http handlers, particularly the registration handlers, will end up as a "internal server error" or "bad request" giving the user very little information about what went wrong.

Some times this is correct when there was some unactionable server side issue, but some times it is within the users power to do something and they should get an error, for example if a token or registration key has expired.

We should make a separate Go error type for user web errors that we can check at the end of all paths to surface to users.

Originally created by @kradalby on GitHub (Jan 29, 2025). At the moment, all errors that occur in http handlers, particularly the registration handlers, will end up as a "internal server error" or "bad request" giving the user very little information about what went wrong. Some times this is correct when there was some unactionable server side issue, but some times it is within the users power to do something and they should get an error, for example if a token or registration key has expired. We should make a separate Go error type for user web errors that we can check at the end of all paths to surface to users.
adam added the enhancement label 2025-12-29 02:26:17 +01:00
adam closed this issue 2025-12-29 02:26:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#930
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?