mirror of
https://github.com/juanfont/headscale.git
synced 2026-01-11 20:00:28 +01:00
[Bug] "headscale node ls --tags" does not list tags after v0.24.0-beta.1 upgrade #889
Closed
opened 2025-12-29 02:25:29 +01:00 by adam
·
13 comments
No Branch/Tag Specified
main
update_flake_lock_action
gh-pages
kradalby/release-v0.27.2
dependabot/go_modules/golang.org/x/crypto-0.45.0
dependabot/go_modules/github.com/opencontainers/runc-1.3.3
copilot/investigate-headscale-issue-2788
copilot/investigate-visibility-issue-2788
copilot/investigate-issue-2833
copilot/debug-issue-2846
copilot/fix-issue-2847
dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0
dependabot/go_modules/github.com/docker/docker-28.3.3incompatible
kradalby/cli-experiement3
doc/0.26.1
doc/0.25.1
doc/0.25.0
doc/0.24.3
doc/0.24.2
doc/0.24.1
doc/0.24.0
kradalby/build-docker-on-pr
topic/docu-versioning
topic/docker-kos
juanfont/fix-crash-node-id
juanfont/better-disclaimer
update-contributors
topic/prettier
revert-1893-add-test-stage-to-docs
add-test-stage-to-docs
remove-node-check-interval
fix-empty-prefix
fix-ephemeral-reusable
bug_report-debuginfo
autogroups
logs-to-stderr
revert-1414-topic/fix_unix_socket
rename-machine-node
port-embedded-derp-tests-v2
port-derp-tests
duplicate-word-linter
update-tailscale-1.36
warn-against-apache
ko-fi-link
more-acl-tests
fix-typo-standalone
parallel-nolint
tparallel-fix
rerouting
ssh-changelog-docs
oidc-cleanup
web-auth-flow-tests
kradalby-gh-runner
fix-proto-lint
remove-funding-links
go-1.19
enable-1.30-in-tests
0.16.x
cosmetic-changes-integration
tmp-fix-integration-docker
fix-integration-docker
configurable-update-interval
show-nodes-online
hs2021
acl-syntax-fixes
ts2021-implementation
fix-spurious-updates
unstable-integration-tests
mandatory-stun
embedded-derp
prtemplate-fix
v0.28.0-beta.1
v0.27.2-rc.1
v0.27.1
v0.27.0
v0.27.0-beta.2
v0.27.0-beta.1
v0.26.1
v0.26.0
v0.26.0-beta.2
v0.26.0-beta.1
v0.25.1
v0.25.0
v0.25.0-beta.2
v0.24.3
v0.25.0-beta.1
v0.24.2
v0.24.1
v0.24.0
v0.24.0-beta.2
v0.24.0-beta.1
v0.23.0
v0.23.0-rc.1
v0.23.0-beta.5
v0.23.0-beta.4
v0.23.0-beta3
v0.23.0-beta2
v0.23.0-beta1
v0.23.0-alpha12
v0.23.0-alpha11
v0.23.0-alpha10
v0.23.0-alpha9
v0.23.0-alpha8
v0.23.0-alpha7
v0.23.0-alpha6
v0.23.0-alpha5
v0.23.0-alpha4
v0.23.0-alpha4-docker-ko-test9
v0.23.0-alpha4-docker-ko-test8
v0.23.0-alpha4-docker-ko-test7
v0.23.0-alpha4-docker-ko-test6
v0.23.0-alpha4-docker-ko-test5
v0.23.0-alpha-docker-release-test-debug2
v0.23.0-alpha-docker-release-test-debug
v0.23.0-alpha4-docker-ko-test4
v0.23.0-alpha4-docker-ko-test3
v0.23.0-alpha4-docker-ko-test2
v0.23.0-alpha4-docker-ko-test
v0.23.0-alpha3
v0.23.0-alpha2
v0.23.0-alpha1
v0.22.3
v0.22.2
v0.23.0-alpha-docker-release-test
v0.22.1
v0.22.0
v0.22.0-alpha3
v0.22.0-alpha2
v0.22.0-alpha1
v0.22.0-nfpmtest
v0.21.0
v0.20.0
v0.19.0
v0.19.0-beta2
v0.19.0-beta1
v0.18.0
v0.18.0-beta4
v0.18.0-beta3
v0.18.0-beta2
v0.18.0-beta1
v0.17.1
v0.17.0
v0.17.0-beta5
v0.17.0-beta4
v0.17.0-beta3
v0.17.0-beta2
v0.17.0-beta1
v0.17.0-alpha4
v0.17.0-alpha3
v0.17.0-alpha2
v0.17.0-alpha1
v0.16.4
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.16.0-beta7
v0.16.0-beta6
v0.16.0-beta5
v0.16.0-beta4
v0.16.0-beta3
v0.16.0-beta2
v0.16.0-beta1
v0.15.0
v0.15.0-beta6
v0.15.0-beta5
v0.15.0-beta4
v0.15.0-beta3
v0.15.0-beta2
v0.15.0-beta1
v0.14.0
v0.14.0-beta2
v0.14.0-beta1
v0.13.0
v0.13.0-beta3
v0.13.0-beta2
v0.13.0-beta1
upstream/v0.12.4
v0.12.4
v0.12.3
v0.12.2
v0.12.2-beta1
v0.12.1
v0.12.0-beta2
v0.12.0-beta1
v0.11.0
v0.10.8
v0.10.7
v0.10.6
v0.10.5
v0.10.4
v0.10.3
v0.10.2
v0.10.1
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.1
v0.8.0
v0.7.1
v0.7.0
v0.6.1
v0.6.0
v0.5.2
v0.5.1
v0.5.0
v0.4.0
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.2
v0.2.1
v0.2.0
v0.1.1
v0.1.0
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/headscale#889
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mhahl on GitHub (Dec 17, 2024).
Is this a support request?
Is there an existing issue for this?
Current Behavior
When running the command.
Shows
Nothing is listed in the
ValidTags,InvalidTags,ForcedTagscolumns.Expected Behavior
When running the command.
I expect the nodes tags to be displayed in the
ValidTags,InvalidTags,ForcedTagscolumns.Steps To Reproduce
headscale nodes ls --tagsEnvironment
Runtime environment
Anything else?
Even tho nothing is displayed in the output, ACLs seems to be working as if the tags were set correctly.
When running the command
tailscale debug netmapI can seeRequestTagsbeing returned.Running the following for a machine which I installed recently also does not return any tags.
Output:
@kradalby commented on GitHub (Dec 17, 2024):
Thanks for the thorough writeup! are you able to test my fixes from here? https://github.com/juanfont/headscale/pull/2309
@mhahl commented on GitHub (Dec 18, 2024):
Hey! Thanks for such a quick response. I have compiled your branch and tested the changes however it does not appear to have changed. The output is exactly the same.
I added some prints to the following lines which appear to only ever return an empty array.
@mhahl commented on GitHub (Dec 18, 2024):
Just checking in the database
db.sqlitelooks like everything is there specifically theRequestTags@kradalby commented on GitHub (Dec 18, 2024):
hmm interesting, the valid tags is a product of the
RequestTagsand the ACL, do you have your ACL? I need to see if I can write up a failing test because the test case we have is currently passing, and I'm not sure why.@mhahl commented on GitHub (Dec 18, 2024):
I'll attach a copy of my ACLs in a moment. I'll try replicate from a fresh setup and perform the upgrade again.
@kradalby commented on GitHub (Dec 18, 2024):
Great, I just push another log line, so you can look for
tags provided by policyin the logs and see if it finds them as authed or unauthed.@mhahl commented on GitHub (Dec 18, 2024):
Here is the config.yaml and acls.json from
headscale policy getwith some of users removed.config.zip
@kradalby commented on GitHub (Dec 18, 2024):
hmm, I added a small test for what I think should be roughly equivalent to your config here
db1aa9ee4d, as I didnt test with the tag owner being a group, but it does look like it passes correctly.I'll be driving and then getting back to this. Not sure what this could be or what has changed, could you look for the
tags provided by policylog lines on a machine you can reproduce it on?@mhahl commented on GitHub (Dec 18, 2024):
Really appreciate the help, I will have to continue debugging tomorrow since its late now. I've attached some output that may or may not help and the logs you requested at the end.
From the server
From my workstation:
(not sure why these are showing up as
emailand not thepreferred_usernamefrom oidc?)Logs from the server.
@kradalby commented on GitHub (Dec 18, 2024):
Email takes precedence if available now, in the future, username will require an
@, at least in the policy.Actually, can you try to use your email in the
group:definition in the Policy? it might be running into the same bug as #2300, I'll try to set up a test that should cover that.If that work, you can use the email, right now this would be considered a regression as I didnt mean to push people towards emails yet.
@mhahl commented on GitHub (Dec 18, 2024):
Changing the acls to use the email works correctly!
@kradalby commented on GitHub (Dec 18, 2024):
ah awesome, that narrows down where I need to look, thank you, I will write a test so I can start figuring out what needs to be fixed.
@mhahl commented on GitHub (Dec 18, 2024):
Thanks very much for your help. Please let me know if you need anything else.