starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

TestOIDC024UserCreation is flaky #884

New Issue
Open
opened 2025-12-29 02:25:12 +01:00 by adam · 1 comment
adam commented 2025-12-29 02:25:12 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Dec 16, 2024).

TestOIDC024UserCreation can flake because user order is not guaranteed, example: https://github.com/juanfont/headscale/actions/runs/12342220536/job/34441801242?pr=2298

We should make the output from the program (sort db output?) or something similar stable output.

Originally created by @kradalby on GitHub (Dec 16, 2024). TestOIDC024UserCreation can flake because user order is not guaranteed, example: https://github.com/juanfont/headscale/actions/runs/12342220536/job/34441801242?pr=2298 We should make the output from the program (sort db output?) or something similar stable output.
adam added the no-stale-bot label 2025-12-29 02:25:12 +01:00
adam commented 2025-12-29 02:25:12 +01:00
Author
Owner
Copy Link

@ljluestc commented on GitHub (May 25, 2025):


package integration

import (
	"context"
	"sort"
	"testing"

	"github.com/juanfont/headscale/integration/hsic"
	"github.com/stretchr/testify/assert"
)

// TestOIDC024UserCreation tests the creation of users via OIDC.
func TestOIDC024UserCreation(t *testing.T) {
	// Setup the integration test context
	integration, err := hsic.NewTestingContext(t, nil)
	assert.NoError(t, err)
	defer integration.Close()

	// Simulate OIDC user creation
	// Replace with actual OIDC setup and user creation logic
	err = integration.CreateUser(context.Background(), "user1")
	assert.NoError(t, err)
	err = integration.CreateUser(context.Background(), "user2")
	assert.NoError(t, err)

	// Retrieve users from the database
	users, err := integration.ListUsers(context.Background())
	assert.NoError(t, err)

	// Sort users by Name to ensure deterministic order
	sort.Slice(users, func(i, j int) bool {
		return users[i].Name < users[j].Name
	})

	// Assert the users are as expected
	expectedUsers := []hsic.User{
		{Name: "user1"},
		{Name: "user2"},
	}
	assert.Equal(t, expectedUsers, users, "Users should match expected list in sorted order")
}

// ListUsers retrieves all users from the database.
// This is a placeholder; replace with actual database query logic.
func (i *hsic.TestingContext) ListUsers(ctx context.Context) ([]hsic.User, error) {
	var users []hsic.User
	// Replace with actual database query, e.g., using GORM or SQL
	// Example: i.DB.Find(&users)
	return users, nil
}

// CreateUser creates a user in the database.
// This is a placeholder; replace with actual OIDC user creation logic.
func (i *hsic.TestingContext) CreateUser(ctx context.Context, name string) error {
	// Replace with actual user creation logic, e.g., via OIDC flow
	return nil
}
@ljluestc commented on GitHub (May 25, 2025): ``` package integration import ( "context" "sort" "testing" "github.com/juanfont/headscale/integration/hsic" "github.com/stretchr/testify/assert" ) // TestOIDC024UserCreation tests the creation of users via OIDC. func TestOIDC024UserCreation(t *testing.T) { // Setup the integration test context integration, err := hsic.NewTestingContext(t, nil) assert.NoError(t, err) defer integration.Close() // Simulate OIDC user creation // Replace with actual OIDC setup and user creation logic err = integration.CreateUser(context.Background(), "user1") assert.NoError(t, err) err = integration.CreateUser(context.Background(), "user2") assert.NoError(t, err) // Retrieve users from the database users, err := integration.ListUsers(context.Background()) assert.NoError(t, err) // Sort users by Name to ensure deterministic order sort.Slice(users, func(i, j int) bool { return users[i].Name < users[j].Name }) // Assert the users are as expected expectedUsers := []hsic.User{ {Name: "user1"}, {Name: "user2"}, } assert.Equal(t, expectedUsers, users, "Users should match expected list in sorted order") } // ListUsers retrieves all users from the database. // This is a placeholder; replace with actual database query logic. func (i *hsic.TestingContext) ListUsers(ctx context.Context) ([]hsic.User, error) { var users []hsic.User // Replace with actual database query, e.g., using GORM or SQL // Example: i.DB.Find(&users) return users, nil } // CreateUser creates a user in the database. // This is a placeholder; replace with actual OIDC user creation logic. func (i *hsic.TestingContext) CreateUser(ctx context.Context, name string) error { // Replace with actual user creation logic, e.g., via OIDC flow return nil } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label no-stale-bot
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#884
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?